perhaps shared libs option is not getting effective. when you send a
v3 please squash Martin's change into that as well.
On Fri, Dec 22, 2023 at 6:10 AM Martin Jansa <martin.ja...@gmail.com> wrote:
>
> Thanks for v2, I've sent additional fix for shared libraries, but there are
> still some probably unexpected side-effects from using CMake and dropping
> lib_package inherit (${PN}-bin removal) as buildhistory shows:
>
> diff --git a/packages/cortexa57-oe-linux/wavpack/sysroot
> b/packages/cortexa57-oe-linux/wavpack/sysroot
> index e772d96dbb5..de2cfdb7b0f 100644
> --- a/packages/cortexa57-oe-linux/wavpack/sysroot
> +++ b/packages/cortexa57-oe-linux/wavpack/sysroot
> @@ -7,10 +7,11 @@ drwxr-xr-x - - 4096
> ./usr/include/wavpack
> drwxr-xr-x - - 4096 ./usr/lib
> drwxr-xr-x - - 4096 ./usr/lib/cmake
> drwxr-xr-x - - 4096 ./usr/lib/cmake/WavPack
> --rw-r--r-- - - 4917
> ./usr/lib/cmake/WavPack/wavpack-config.cmake
> --rw-r--r-- - - 2470
> ./usr/lib/cmake/WavPack/wavpack-config-noconfig.cmake
> +-rw-r--r-- - - 4678
> ./usr/lib/cmake/WavPack/wavpack-config.cmake
> +-rw-r--r-- - - 2484
> ./usr/lib/cmake/WavPack/wavpack-config-noconfig.cmake
> -rw-r--r-- - - 3675
> ./usr/lib/cmake/WavPack/wavpack-config-version.cmake
> --rw-r--r-- - - 1006290 ./usr/lib/libwavpack.a
> +-rwxr-xr-x - - 199048 ./usr/lib/libwavpack.so.5.6.0
> +lrwxrwxrwx - - 19 ./usr/lib/libwavpack.so ->
> libwavpack.so.5.6.0
> drwxr-xr-x - - 4096 ./usr/lib/pkgconfig
> -rw-r--r-- - - 234 ./usr/lib/pkgconfig/wavpack.pc
> drwxr-xr-x - - 4096 ./usr/share
>
>
> diff --git a/packages/cortexa57-oe-linux/wavpack/wavpack/latest
> b/packages/cortexa57-oe-linux/wavpack/wavpack/latest
> index d1d7db3e993..4e8fd7e2f20 100644
> --- a/packages/cortexa57-oe-linux/wavpack/wavpack/latest
> +++ b/packages/cortexa57-oe-linux/wavpack/wavpack/latest
> @@ -1,10 +1,9 @@
> -PV = 5.1.0
> +PV = 5.6.0
> PR = r0
> -PKG = libwavpack1
> -PKGR = r0.0
> -RPROVIDES = wavpack (=5.1.0)
> +PKGR = r0.2
> +RPROVIDES =
> RDEPENDS = glibc (>= 2.38+git0+1e04dcec49)
> RRECOMMENDS =
> -PKGSIZE = 199171
> +PKGSIZE = 608176
> FILES = /usr/bin/* /usr/sbin/* /usr/libexec/* /usr/lib/lib*.so.* /etc /com
> /var /usr/bin/* /usr/sbin/* /usr/lib/*.so.* /lib/udev /usr/lib/udev
> /usr/lib/udev /usr/lib/udev /usr/share/wavpack /usr/lib/wavpack/*
> /usr/share/pixmaps /usr/shar
> e/applications /usr/share/idl /usr/share/omf /usr/share/sounds
> /usr/lib/bonobo/servers
> -FILELIST = /usr/lib/libwavpack.so.1 /usr/lib/libwavpack.so.1.2.0
> +FILELIST = /usr/bin/wavpack /usr/bin/wvgain /usr/bin/wvtag /usr/bin/wvunpack
> /usr/lib/libwavpack.so.5.6.0
>
> diff --git a/packages/cortexa57-oe-linux/wavpack/wavpack-bin/latest
> b/packages/cortexa57-oe-linux/wavpack/wavpack-bin/latest
> deleted file mode 100644
> index 3a1b182efce..00000000000
> --- a/packages/cortexa57-oe-linux/wavpack/wavpack-bin/latest
> +++ /dev/null
> @@ -1,10 +0,0 @@
> -PV = 5.1.0
> -PR = r0
> -PKG = libwavpack-bin
> -PKGR = r0.0
> -RPROVIDES = wavpack-bin (=5.1.0)
> -RDEPENDS = glibc (>= 2.38+git0+1e04dcec49) wavpack (>= 5.1.0)
> -RRECOMMENDS =
> -PKGSIZE = 408992
> -FILES = /usr/bin/* /usr/sbin/*
> -FILELIST = /usr/bin/wavpack /usr/bin/wvgain /usr/bin/wvtag /usr/bin/wvunpack
>
>
>
> On Thu, Dec 21, 2023 at 3:11 PM alper ak <alperyasin...@gmail.com> wrote:
>>
>> Added openssl as a depends and sent v2 patch, thank you.
>>
>> Martin Jansa <martin.ja...@gmail.com>, 21 Ara 2023 Per, 15:30
>> tarihinde şunu yazdı:
>> >
>> > Adding the dependency on target openssl allows the build to finish OK.
>> >
>> > On Thu, Dec 21, 2023 at 1:06 PM Martin Jansa via lists.openembedded.org
>> > <martin.jansa=gmail....@lists.openembedded.org> wrote:
>> >>
>> >> Hi,
>> >>
>> >> it seems to be trying to link with native libcrypto in some builds:
>> >>
>> >> lib32-wavpack/5.6.0/recipe-sysroot-native/usr/lib/libcrypto.so: file not
>> >> recognized: file format not recognized
>> >> collect2: error: ld returned 1 exit status
>> >>
>> >> have you tried to build it e.g. for aarch64 or arm on x86_64 build host?
>> >>
>> >> On Wed, Dec 20, 2023 at 7:25 AM Alper Ak <alperyasin...@gmail.com> wrote:
>> >>>
>> >>> License-Update: Copyright year changes
>> >>>
>> >>> Changelog:
>> >>>
>> >>> * added: AIFF file import/export support
>> >>> * added: WATCOM compiler and OS/2 support
>> >>> * added: cmake support for mingw, builds Cooledit + Winamp plugins
>> >>> * added: --force-even-byte-depth option for rounding up bit depths
>> >>> * fixed: detect and report PCM files having non-zero padding bits
>> >>> * fixed: possible crash when displaying long channel assignments
>> >>> * fixed: big-endian-sourced "raw" files gave big-endian "wav"s
>> >>> * fixed: numerous minor issues
>> >>> * fixed: CVE-2021-44269 (encoding crafted DSD file triggers OOB read
>> >>> crash)
>> >>> * fixed: very long filenames cause stack-overflow crash in all CLI
>> >>> programs
>> >>> * fixed: the length stored in WAV headers not always corrected when
>> >>> using -i
>> >>> * fixed: attempting to encode raw DSD audio from stdin sometimes causes
>> >>> crash
>> >>> * fixed: DSD to PCM decimation: small clicks between tracks and tiny DC
>> >>> offset
>> >>> * fixed: length update in library-generated WAV headers on big-endian
>> >>> machines
>> >>> * fixed: sanitize custom extensions read from WavPack files to be
>> >>> alphanumeric
>> >>> * added: accepting brace-delimited options in the wavpack executable
>> >>> filename
>> >>> * added: "--drop" option to Windows executables for multi-file
>> >>> "drag-and-drop"
>> >>> * added" "--raw-pcm" option to wvunpack executable (does DSD --> 24-bit
>> >>> PCM)
>> >>> * added: "--no-overwrite" option to wavpack executable (to resume
>> >>> sessions)
>> >>> * improved: build system clean-up including switch to non-recursive
>> >>> "make"
>> >>> * fixed: potential security issue CVE-2020-35738
>> >>> * fixed: disable A32 asm code when building for Apple silicon
>> >>> * fixed: issues with Adobe-style floating-point WAV files
>> >>> * added: -vv option to wvunpack to quickly verify using just
>> >>> block checksums (ideal for detecting corrupted files)
>> >>> * added: --normalize-floats option to wvunpack for correctly
>> >>> exporting un-normalized floating-point files
>> >>> * updated: Visual Studio 2019 for Windows builds
>> >>> * dropped: WinXP support in official binaries
>> >>> * fixed: OSS-Fuzz issues 19925, 19928, 20060, 20448
>> >>> (no CVEs or vulnerabilities)
>> >>> * fixed: trailing garbage characters on imported ID3v2 TXXX tags
>> >>> * fixed: various minor undefined behavior and memory access issues
>> >>> * fixed: sanitize tag extraction names for length and path inclusion
>> >>> * improved: reformat wvunpack "help" and split into long + short versions
>> >>> * added: regression testing to Travis CI for OSS-Fuzz crashers
>> >>> * fixed: potential security issues including the following CVEs:
>> >>> CVE-2018-19840 CVE-2018-19841 CVE-2018-10536
>> >>> CVE-2018-10537 CVE-2018-10538 CVE-2018-10539
>> >>> CVE-2018-10540 CVE-2018-7254 CVE-2018-7253
>> >>> CVE-2018-6767
>> >>> * added: support for CMake, Travis CI, and Google's OSS-fuzz
>> >>> * fixed: use correction file for encode verify (pipe input, Windows)
>> >>> * fixed: correct WAV header with actual length (pipe input, -i option)
>> >>> * fixed: thumb interworking and not needing v6 architecture (ARM asm)
>> >>> * added: handle more ID3v2.3 tag items and from all file types
>> >>> * fixed: coredump on Sparc64 (changed MD5 implementation)
>> >>> * fixed: handle invalid ID3v2.3 tags from sacd-ripper
>> >>> * fixed: several corner-case memory leaks
>> >>>
>> >>> Signed-off-by: alperak <alperyasin...@gmail.com>
>> >>> ---
>> >>> .../wavpack/{wavpack_5.1.0.bb => wavpack_5.6.0.bb} | 6 +++---
>> >>> 1 file changed, 3 insertions(+), 3 deletions(-)
>> >>> rename meta-oe/recipes-multimedia/wavpack/{wavpack_5.1.0.bb =>
>> >>> wavpack_5.6.0.bb} (63%)
>> >>>
>> >>> diff --git a/meta-oe/recipes-multimedia/wavpack/wavpack_5.1.0.bb
>> >>> b/meta-oe/recipes-multimedia/wavpack/wavpack_5.6.0.bb
>> >>> similarity index 63%
>> >>> rename from meta-oe/recipes-multimedia/wavpack/wavpack_5.1.0.bb
>> >>> rename to meta-oe/recipes-multimedia/wavpack/wavpack_5.6.0.bb
>> >>> index 909612393..80671896c 100644
>> >>> --- a/meta-oe/recipes-multimedia/wavpack/wavpack_5.1.0.bb
>> >>> +++ b/meta-oe/recipes-multimedia/wavpack/wavpack_5.6.0.bb
>> >>> @@ -1,9 +1,9 @@
>> >>> DESCRIPTION = "WavPack is a completely open audio compression format
>> >>> providing lossless, high-quality lossy, and a unique hybrid compression
>> >>> mode."
>> >>> LICENSE = "BSD-3-Clause"
>> >>> -LIC_FILES_CHKSUM =
>> >>> "file://license.txt;md5=8c1a910e5c2a8b30ec8ffb2ffa63d9b2"
>> >>> +LIC_FILES_CHKSUM =
>> >>> "file://license.txt;md5=bb5d037e3ad41a3c84c9f2d8bb65a7b4"
>> >>>
>> >>> SRC_URI =
>> >>> "git://github.com/dbry/WavPack.git;branch=master;protocol=https"
>> >>> -SRCREV = "9ccc3fe4a37d069137ceabe513a4dd9b0a09c1c2"
>> >>> +SRCREV = "e03e8e29dc618e08e7baba9636e57ba1254874ce"
>> >>> S = "${WORKDIR}/git"
>> >>>
>> >>> -inherit autotools lib_package
>> >>> +inherit cmake pkgconfig
>> >>> --
>> >>> 2.25.1
>> >>>
>> >>>
>> >>>
>> >>>
>> >>
>> >>
>> >>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#107752):
https://lists.openembedded.org/g/openembedded-devel/message/107752
Mute This Topic: https://lists.openembedded.org/mt/103277174/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
