Upstream-Status: Backport from 
https://gitlab.com/wireshark/wireshark/-/commit/a8586fde3a6512466afb2a660538ef3fe712076b

Signed-off-by: Hitendra Prajapati <hprajap...@mvista.com>
---
 .../wireshark/files/CVE-2024-0208.patch       | 42 +++++++++++++++++++
 .../wireshark/wireshark_3.2.18.bb             |  1 +
 2 files changed, 43 insertions(+)
 create mode 100644 
meta-networking/recipes-support/wireshark/files/CVE-2024-0208.patch

diff --git 
a/meta-networking/recipes-support/wireshark/files/CVE-2024-0208.patch 
b/meta-networking/recipes-support/wireshark/files/CVE-2024-0208.patch
new file mode 100644
index 0000000000..c4dfb6c37d
--- /dev/null
+++ b/meta-networking/recipes-support/wireshark/files/CVE-2024-0208.patch
@@ -0,0 +1,42 @@
+From a8586fde3a6512466afb2a660538ef3fe712076b Mon Sep 17 00:00:00 2001
+From: John Thacker <johnthac...@gmail.com>
+Date: Thu, 23 Nov 2023 13:47:51 -0500
+Subject: [PATCH] gvcp: Don't try to add a NULL string to a column
+
+This was caught as an invalid argument by g_strlcpy before 4.2,
+but it was never a good idea.
+
+Fix #19496
+
+Upstream-Status: Backport 
[https://gitlab.com/wireshark/wireshark/-/commit/a8586fde3a6512466afb2a660538ef3fe712076b]
+CVE: CVE-2024-0208
+Signed-off-by: Hitendra Prajapati <hprajap...@mvista.com>
+---
+ epan/dissectors/packet-gvcp.c | 7 ++-----
+ 1 file changed, 2 insertions(+), 5 deletions(-)
+
+diff --git a/epan/dissectors/packet-gvcp.c b/epan/dissectors/packet-gvcp.c
+index 2de4552..b94ddea 100644
+--- a/epan/dissectors/packet-gvcp.c
++++ b/epan/dissectors/packet-gvcp.c
+@@ -2222,15 +2222,12 @@ static void dissect_readreg_ack(proto_tree 
*gvcp_telegram_tree, tvbuff_t *tvb, p
+                       if (addr_list_size > 0)
+                       {
+                               address_string = 
get_register_name_from_address(*((guint32*)wmem_array_index(gvcp_trans->addr_list,
 0)), gvcp_info, &is_custom_register);
++                              col_append_str(pinfo->cinfo, COL_INFO, 
address_string);
+                       }
+ 
+                       if (num_registers)
+                       {
+-                              col_append_fstr(pinfo->cinfo, COL_INFO, "%s 
Value=0x%08X", address_string, tvb_get_ntohl(tvb, offset));
+-                      }
+-                      else
+-                      {
+-                              col_append_str(pinfo->cinfo, COL_INFO, 
address_string);
++                              col_append_sep_fstr(pinfo->cinfo, COL_INFO, " 
", "Value=0x%08X", tvb_get_ntohl(tvb, offset));
+                       }
+               }
+       }
+-- 
+2.25.1
+
diff --git a/meta-networking/recipes-support/wireshark/wireshark_3.2.18.bb 
b/meta-networking/recipes-support/wireshark/wireshark_3.2.18.bb
index 7d99a1438b..b36a0acbfb 100644
--- a/meta-networking/recipes-support/wireshark/wireshark_3.2.18.bb
+++ b/meta-networking/recipes-support/wireshark/wireshark_3.2.18.bb
@@ -21,6 +21,7 @@ SRC_URI = 
"https://1.eu.dl.wireshark.org/src/all-versions/wireshark-${PV}.tar.xz
            file://CVE-2023-3649.patch \
            file://CVE-2022-0585-CVE-2023-2879.patch \
            file://CVE-2022-4345.patch \
+           file://CVE-2024-0208.patch \
            "
 UPSTREAM_CHECK_URI = "https://1.as.dl.wireshark.org/src";
 
-- 
2.25.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#108206): 
https://lists.openembedded.org/g/openembedded-devel/message/108206
Mute This Topic: https://lists.openembedded.org/mt/103636214/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to