> -----Original Message-----
> From: Khem Raj <raj.k...@gmail.com>
> Sent: Monday, March 4, 2024 3:50 PM
> To: Slater, Joseph <joe.sla...@windriver.com>
> Cc: openembedded-devel@lists.openembedded.org; MacLeod, Randy
> <randy.macl...@windriver.com>
> Subject: Re: [oe] [meta-oe][PATCH 1/1] googletest: allow for shared libraries
>
> On Mon, Mar 4, 2024 at 1:50 PM Joe Slater via lists.openembedded.org
> <joe.slater=windriver....@lists.openembedded.org> wrote:
> >
> > From: Joe Slater <joe.sla...@windriver.com>
> >
> > Add a PACKAGECONFIG option to produce shared libraries.
> > Allow staticdev to be empty if no static libraries are built.
> >
>
> why would be not build static libs ? and if we do not then why do we need to
> create empty package ?
If we set -DBUILD_SHARED_LIBS=ON static libs will not be built and -staticdev
will not be created, so -dev will produce an error if we try to, for example,
populate an sdk. I guess we could put static libs in -dev and get rid of
-staticdev, but I didn't want to mess with the packaging.
Joe
>
> > Signed-off-by: Joe Slater <joe.sla...@windriver.com>
> > ---
> > meta-oe/recipes-test/googletest/googletest_1.14.0.bb | 8 +++++++-
> > 1 file changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta-oe/recipes-test/googletest/googletest_1.14.0.bb
> > b/meta-oe/recipes-test/googletest/googletest_1.14.0.bb
> > index 8c75f936de..1b05f3d336 100644
> > --- a/meta-oe/recipes-test/googletest/googletest_1.14.0.bb
> > +++ b/meta-oe/recipes-test/googletest/googletest_1.14.0.bb
> > @@ -10,11 +10,17 @@ S = "${WORKDIR}/git"
> > SRCREV = "f8d7d77c06936315286eb55f8de22cd23c188571"
> > SRC_URI =
> "git://github.com/google/googletest.git;branch=main;protocol=https"
> >
> > -inherit cmake
> > +inherit cmake pkgconfig
> > +
> > +# allow for shared libraries, but do not default to them #
> > +PACKAGECONFIG[shared] = "-DBUILD_SHARED_LIBS=ON,-
> DBUILD_SHARED_LIBS=OFF,,"
> > +
> >
> > ALLOW_EMPTY:${PN} = "1"
> > ALLOW_EMPTY:${PN}-dbg = "1"
> >
> > +ALLOW_EMPTY:${PN}-staticdev = "1"
> > RDEPENDS:${PN}-dev += "${PN}-staticdev"
> >
> > BBCLASSEXTEND = "native nativesdk"
> > --
> > 2.25.1
> >
> >
> >
> >
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#109125):
https://lists.openembedded.org/g/openembedded-devel/message/109125
Mute This Topic: https://lists.openembedded.org/mt/104732413/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
