On Fri, Oct 11, 2024 at 8:51 AM Yoann Congal <[email protected]> wrote:
>
>
>
> Le ven. 11 oct. 2024 à 17:37, Khem Raj <[email protected]> a écrit :
>>
>> On Fri, Oct 11, 2024 at 8:34 AM Yoann Congal <[email protected]> wrote:
>> >
>> >
>> >
>> > Le ven. 11 oct. 2024 à 17:15, Khem Raj <[email protected]> a écrit :
>> >>
>> >> On Fri, Oct 11, 2024 at 8:10 AM Yoann Congal via
>> >> lists.openembedded.org <[email protected]>
>> >> wrote:
>> >> >
>> >> > From: Yoann Congal <[email protected]>
>> >> >
>> >> > gimptool can be used in GIMP plugin compilation. It would make more
>> >> > sense as a native tool. It also contains the sysroot path which break
>> >> > build with buildpaths QA error. Remove it from target packages.
>> >> >
>> >> > Signed-off-by: Yoann Congal <[email protected]>
>> >> > ---
>> >> > meta-gnome/recipes-gimp/gimp/gimp_2.10.38.bb | 7 +++++++
>> >> > 1 file changed, 7 insertions(+)
>> >> >
>> >> > diff --git a/meta-gnome/recipes-gimp/gimp/gimp_2.10.38.bb
>> >> > b/meta-gnome/recipes-gimp/gimp/gimp_2.10.38.bb
>> >> > index a17e03b103..8755af94a9 100644
>> >> > --- a/meta-gnome/recipes-gimp/gimp/gimp_2.10.38.bb
>> >> > +++ b/meta-gnome/recipes-gimp/gimp/gimp_2.10.38.bb
>> >> > @@ -70,6 +70,13 @@ do_compile:prepend() {
>> >> > export GEGL_PATH=`find ${STAGING_LIBDIR_NATIVE} -maxdepth 1 -name
>> >> > 'gegl-*'`
>> >> > }
>> >> >
>> >> > +do_install:append:class-target() {
>> >> > + # gimptool can be used in GIMP plugin compilation. It would make
>> >> > more sense
>> >> > + # as a native tool. It also contains the sysroot path which break
>> >> > build
>> >> > + # with buildpaths QA error. Remove it from target packages.
>> >> > + rm ${D}/${bindir}/gimptool-2.0
>> >> > +}
>> >>
>> >> it does mean we can't build plugins in a usecase where an on-device
>> >> SDK is being used, even though it is a rare usecase.
>> >> Can we explore a way to omit the sysroot from being emitted into the
>> >> target version of gimptool ?
>> >
>> >
>> > Sure!
>> >
>> > Right now, Host CC is embedded in the target binary as a last-resort
>> > default to make gimptool output a reasonable CC for gimp plugins
>> > compilation.
>> > I don't see how to provide a good value to put there unless I can get the
>> > CC that will be used in the target SDK? (I don't think I can)
>> >
>>
>> Perhaps replacing instances of SYSROOT with target exec_prefix in CC
>> emitted to binary would be a workable solution.
>
>
> For Poky/qemux86-64, that would output
> CC="x86_64-poky-linux-gcc -m64 -march=core2 -mtune=core2 -msse3 -mfpmath=sse
> -fstack-protector-strong -O2 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security
> -Werror=format-security --sysroot=/usr"
>
> Does this look correct to you? (I've never tried the target SDK) Is the
> compiler really called "x86_64-poky-linux-gcc" (or just "gcc")?
>
Just remove the --sysroot option completely.
>>
>> > What do you think about removing this last-resort default with a patch?
>> > That would make gimptool dependent on a correct CC being provided to it
>> > (but the target SDK should already do that)
>> >
>> >>
>> >> > +
>> >> > FILES:${PN} += "${datadir}/metainfo"
>> >> >
>> >> > RDEPENDS:${PN} += "mypaint-brushes-1.0"
>> >> >
>> >> >
>> >> >
>> >
>> >
>> >
>> > --
>> > Yoann Congal
>> > Smile ECS - Tech expert
>
>
>
> --
> Yoann Congal
> Smile ECS - Tech expert
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#112812):
https://lists.openembedded.org/g/openembedded-devel/message/112812
Mute This Topic: https://lists.openembedded.org/mt/108950447/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
