On Thu, Oct 31, 2024 at 7:15 PM Martin Jansa via lists.openembedded.org <[email protected]> wrote: > > Yes, systemd_system_unitdir helps with the systemd files, but the other files: > /usr/lib/snapper/systemd-helper > /usr/lib/snapper/installation-helper > /usr/lib/snapper/plugins > > don't use systemd_system_unitdir and as the path to them is hardcoded > in the source, I guess we should either hardcode the path in FILES as > well (so that they are still packaged and found in runtime even if > someone changes libdir value) or change both the code and the > packaging to respect libdir (which might be too much to ask after > looking at the Makefile.am). > > I have a .patch file to change Makefile.am to allow passing PREFIX, > LIBDIR, DATADIR, SYSTEMDDIR values, but then I've noticed plugins and > helpers and stopped there (as I changing that as well to respect > passed LIBDIR) should be at least partially tested in runtime which I > wasn't planning to. Sending PR with just Makefile.am changes and > asking the developers to "finish it" also probably won't help much, so > I've just sent previous e-mail and added SKIP_RECIPE in our DISTRO > with multilib. I can share the draft PR if someone finds that useful.
Added libdir configuration for those paths and here is slightly updated version: https://git.openembedded.org/meta-openembedded-contrib/log/?h=jansa/snapper completely not tested in runtime, I've only checked that lib32-snapper builds without installed-vs-shipped and the most files look in expected locations (but I guess /usr/lib32/security/pam_snapper.so should be moved to nonarch libdir, so it would need separate configure param from currently used libdir). Not sure if this was worth it :). lib32-snapper/0.11.2 $ find image/usr/lib* image/usr/lib image/usr/lib/systemd image/usr/lib/systemd/system image/usr/lib/systemd/system/snapper-boot.timer image/usr/lib/systemd/system/snapperd.service image/usr/lib/systemd/system/snapper-boot.service image/usr/lib/systemd/system/snapper-timeline.timer image/usr/lib/systemd/system/snapper-cleanup.service image/usr/lib/systemd/system/snapper-cleanup.timer image/usr/lib/systemd/system/snapper-timeline.service image/usr/lib32 image/usr/lib32/libsnapper.so image/usr/lib32/libsnapper.so.7 image/usr/lib32/snapper image/usr/lib32/snapper/systemd-helper image/usr/lib32/snapper/plugins image/usr/lib32/snapper/testsuite image/usr/lib32/snapper/testsuite/owner1 image/usr/lib32/snapper/testsuite/CAUTION image/usr/lib32/snapper/testsuite/permissions2 image/usr/lib32/snapper/testsuite/xattrs3 image/usr/lib32/snapper/testsuite/error4 image/usr/lib32/snapper/testsuite/xattrs4 image/usr/lib32/snapper/testsuite/setup-and-run-all image/usr/lib32/snapper/testsuite/ug-tests image/usr/lib32/snapper/testsuite/ascii-file image/usr/lib32/snapper/testsuite/xattrs1 image/usr/lib32/snapper/testsuite/xattrs2 image/usr/lib32/snapper/testsuite/directory1 image/usr/lib32/snapper/testsuite/owner3 image/usr/lib32/snapper/testsuite/permissions3 image/usr/lib32/snapper/testsuite/test-btrfsutils image/usr/lib32/snapper/testsuite/error1 image/usr/lib32/snapper/testsuite/permissions1 image/usr/lib32/snapper/testsuite/missing-directory1 image/usr/lib32/snapper/testsuite/simple1 image/usr/lib32/snapper/testsuite/owner2 image/usr/lib32/snapper/testsuite/error2 image/usr/lib32/snapper/testsuite/run-all image/usr/lib32/snapper/installation-helper image/usr/lib32/pam_snapper image/usr/lib32/pam_snapper/pam_snapper_useradd.sh image/usr/lib32/pam_snapper/pam_snapper_pamconfig.sh image/usr/lib32/pam_snapper/pam_snapper_homeconvert.sh image/usr/lib32/pam_snapper/pam_snapper_userdel.sh image/usr/lib32/security image/usr/lib32/security/pam_snapper.so image/usr/lib32/libsnapper.so.7.4.3
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#113377): https://lists.openembedded.org/g/openembedded-devel/message/113377 Mute This Topic: https://lists.openembedded.org/mt/109116183/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
