Review: Needs Information

I don't see a problem having these modules here. About the code: there is a 
migration script, and I think its purpose is to update existing products upon 
installation of the module. However, I don't think the script is run at module 
installation time. Are you sure that this is the case?

Otherwise, you will need to put it in the model's _auto_init() method. It will 
run every time the module is upgraded (or installed) but that should not hurt. 
What you can do is check if column 'procurement_type' exists, call super() and 
run the migration queries only if the column did not exist when you checked. 
This indicates the installation of the module.

-- 
https://code.launchpad.net/~camptocamp/sale-wkfl/product_procurement_type/+merge/207638
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to     : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Reply via email to