Review: Needs Fixing Very useful, thanks!
Some remarks though: Generally, you don't need most of your backslashes (ie when in a bracketed term) - removing them improves readability imho #30 it's Functionality (-n) #353 openerp.tools.safe_eval.literal_eval would do the same thing #388 I guess you want to safe the dependency on email.template here? #390ff you use multiline strings without actually using them. Why? Wouldn't it make sense to swap #451 and #454? The usual (and thus the one that should be the fastest) case will be that a user logs in with her own password. And +1 for including the full license in every file -- https://code.launchpad.net/~sylvain-legal/server-env-tools/7.0-auth_admin_passkey/+merge/211338 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp