Review: Approve On a low-level, I see that elements of curr_ids that are not in ids should not change the result. So I approve the fix.
On the other hand, I don't get what the method does. Could you take the occasion to add a docstring or comment, and maybe rename tid, ids, curr_ids ... thanks! -- https://code.launchpad.net/~camptocamp/account-consolidation/fix-domain-nbi/+merge/216331 Your team Account Core Editors is requested to review the proposed merge of lp:~camptocamp/account-consolidation/fix-domain-nbi into lp:account-consolidation/7.0. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp