Review: Needs Fixing code review, no tests

Hi,

Sorry I miss something :

Line 24 and 55, if employee has no department_id define, the code will break.

Can you please add a test on department_id.

Regards,
-- 
https://code.launchpad.net/~jb.eficent/department-mgmt/department-mgmt-bugfix-1296055/+merge/212286
Your team Department Core Editors is subscribed to branch lp:department-mgmt.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to     : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Reply via email to