Review: Needs Fixing
Thanks Nicolas. A few small remarks up to line 1300:
- l138 typo
- l143 seems like you are copying twice
- l145 (non-blocking) i'm not sure if it's better to set a key to false or
remove a key from defaults (like in defaults.pop('field_name', None) )
- "manually_overriden" -> manually_overridden
- l438 "that policy correspond" -> "that the policy corresponds"
- l445 slightly more readable if "if" goes to the next line
- l1013 line -> lines
--
https://code.launchpad.net/~camptocamp/account-financial-tools/add-manual-line-and-fees-nbi/+merge/218584
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-financial-tools.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
