Review: Approve functionnal and code

Dear Ronald Portier,
Thanks for your work. I tested them and functionally they look just fine.
The UI could be simpler: you could make the fields "hidden" instead of 
"read-only" when a pricelist lines have a fixed price.
Then the additional menu entries and views wouldn't be needed, you could remove 
them altogether.
Regarding the many files, usually we group them by module so you could do with 
a "product.py" with all things product-related. But I'd not block this MP for 
such a detail.
And other that that it looks just fine to me.

Pedro Manuel Baeza, I humbly think we should accept this MP, and then you can 
base your own branch on Ronald Portier's work. What do you think?
-- 
https://code.launchpad.net/~therp-nl/openerp-product-attributes/7.0_lp1272282_fixed_price/+merge/203348
Your team OpenERP Community is subscribed to branch 
lp:openerp-product-attributes.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : openerp-community@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp

Reply via email to