Hi Rob and Nick,

The following seems to be a problem with FlowVisor.

In the spec, vendor extension such as OFPST_VENDOR and OFPAT_VENDOR is
defined as 0xffff. However, FlowVisor has tables that doesn't assume
0xffff (or -1 in signed short). For example:

static final Class convertStatsRequestMap[] = {
        FVDescriptionStatistics.class, FVFlowStatisticsRequest.class,
        FVAggregateStatisticsRequest.class, FVTableStatistics.class,
        FVPortStatisticsRequest.class, FVQueueStatisticsRequest.class,
        FVVendorStatistics.class };

Since FVMessageFactory.getStatistics() in OpenFlowJ actually returns
-1 (0xffff), the caller(FlowVisor) should convert it to 6 (or the last
entry of the table) for accessing convertStatsRequestMap[]. Potentially,
there are same problems in accessing convertStatsReplyMap[] and
convertActionsMap[], I guess.

I haven't prepared a patch for this problem this time. Sorry.


Best regards,

Masahiko.
_______________________________________________
openflow-discuss mailing list
openflow-discuss@lists.stanford.edu
https://mailman.stanford.edu/mailman/listinfo/openflow-discuss

Reply via email to