Ok, all the comments are in https://git.opendaylight.org/gerrit/#/c/37937/, I have added my comments, I just pasted them here for your reference. You and Anil aren’t in this discussion context, so you don’t know them.
“”” Maybe you don't know the context, the previous nsh support in Openflowplugin project is for the old nsh implemented CISCO guy Pretish did, but now CISCO has agreed Intel to take over their work, ovs didn't include any code for nsh so far, Intel is doing this, but the road to go is long, CISCO and Redhat and Intel have had an agreement on this, we are NSH implementation owner, the part in ODL (this patch you reviewed) is part of this effort. Nobody or no organization is defining NSH Openflow interface standard, our NSH implementation is standard ☺ Current issue is CISCO ovs nsh support patch isn’t maintained any more, so I published one new version based on the latest ovs, it is just to make sure we can have a new version available for ODL integration, all the people are anticipating it. Even NSH isn't standardized, it is now IETF draft, so NSH itself will be possibly subject to change :-), we're struggling to upstream it to ovs, but the progress is very low, Redhat guy has paved the road for VxLAN-gpe in Linux net-next, we're refactoring our NSH kernel patch based on this VxLAN-gpe implementation, this low progress obviously impacts on our ODL use. This patch is to finalize Openflow interface, the final upstreamed version in ovs will follow these Openflow interface. We need to use these to fix our ovsdb/netvirt and sfc integration issue. We are only one NSH implementer, don't worry other people will change it. Because NSH support isn't upstreamed to ovs, so it is impossible to be compatible backwards with Beryllium, Openflowplugin must be changed to adapt to ovs changes, action ID and match field ID are always changing before upstream. We're trying our best to make sure the final upstreamed version in ovs won't need changes in Openflowplugin or just need tiny changes, such as action ID and match field ID (this depends on when they are upstreamed, the more we need to change, the later they are upstreamed). “”” From: Abhijit Kumbhare [mailto:abhijitk...@gmail.com] Sent: Tuesday, May 10, 2016 9:46 AM To: Yang, Yi Y <yi.y.y...@intel.com>; openflowplugin-dev@lists.opendaylight.org Subject: Re: [openflowplugin-dev] OpenFlow Plugin Meeting Minutes May 9, 2016 I guess I did not capture the details in the minutes - here they are: Anil raised some concerns about the patch that this is dependent on work in Linux kernel and OVS - and that the upstream changes will incur changes to this patch in the future. His concern was that currently this patch does not keep backward compatibility for Srini's and Ed's patches earlier - but he thinks that may be OK as the earlier work is not used somewhere. On the other hand the concern he had was that the code may have to be changed in the future (depending on OVS & Linux kernel) - and in future it may be hard to keep backward compatibility to this current work that you have done. He was planning to send an email to the OpenFlow plugin mailing list about this for their concerns - and then merge. On Mon, May 9, 2016 at 6:27 PM, Yang, Yi Y <yi.y.y...@intel.com<mailto:yi.y.y...@intel.com>> wrote: Hi, Abhijit So what is next step for https://git.opendaylight.org/gerrit/#/c/37937/ ? From: openflowplugin-dev-boun...@lists.opendaylight.org<mailto:openflowplugin-dev-boun...@lists.opendaylight.org> [mailto:openflowplugin-dev-boun...@lists.opendaylight.org<mailto:openflowplugin-dev-boun...@lists.opendaylight.org>] On Behalf Of Abhijit Kumbhare Sent: Tuesday, May 10, 2016 2:09 AM To: openflowplugin-dev@lists.opendaylight.org<mailto:openflowplugin-dev@lists.opendaylight.org> Subject: [openflowplugin-dev] OpenFlow Plugin Meeting Minutes May 9, 2016 --------------------------------------------------------- Browser Friendly format meeting minutes: --------------------------------------------------------- http://meetings.opendaylight.org/opendaylight-openflowplugin/2016/openflow_plugin_may_9__2016/opendaylight-openflowplugin-openflow_plugin_may_9__2016.2016-05-09-16.04.html ---------------------------------------------------------------------------------------------- Text format friendly for direct linking of lists.opendaylight.org<http://lists.opendaylight.org/> archives: ---------------------------------------------------------------------------------------------- Meeting summary --------------- * Agenda (abhijitkumbhare, 16:05:14) * M3 items - bugs for the new design for projects (abhijitkumbhare, 16:05:44) * NSH patch from Yi Yang (abhijitkumbhare, 16:06:16) * BluePrint (abhijitkumbhare, 16:06:48) * TWS topic - merge of OpenFlow projects (abhijitkumbhare, 16:07:34) * Merges pending / code reviews (abhijitkumbhare, 16:08:05) * BluePrint (abhijitkumbhare, 16:08:47) * TomP has couple of draft patches for BluePrint (abhijitkumbhare, 16:10:49) * M3 items - bugs for the new design from the dependent projects (abhijitkumbhare, 16:22:24) * L2 switch blocker - goes to the switch but not the stats: https://bugs.opendaylight.org/show_bug.cgi?id=5822 (abhijitkumbhare, 16:26:40) * 5822 needed for migration (abhijitkumbhare, 16:28:27) * Regression of the functionality - target for M4 (abhijitkumbhare, 16:29:41) * 5659 - not related to Li Migration (abhijitkumbhare, 16:31:23) * Bug 5602: Blocker for Li migration for VTN project (abhijitkumbhare, 16:34:08) * LINK: https://bugs.opendaylight.org/show_bug.cgi?id=5692 (hideyuki, 16:39:23) * Blocker bugs for Li migration default change would be: 5692, 5602 & 4671 (abhijitkumbhare, 16:43:52) * ACTION: eshuvka_ to take a quick look at 5602; after that will likely need jbacigal to take over (abhijitkumbhare, 16:46:37) * ACTION: jbacigal looking into 4671 with michal_rehak (abhijitkumbhare, 16:47:07) * ACTION: hideyuki to take a look into 5692 if it can wait after the migration - since the estimate from Tomas Slusny for this M4 (abhijitkumbhare, 16:48:20) * NSH patch from Yi Yang (abhijitkumbhare, 16:49:22) * vishnoianil has some concerns - there was some previous work by Srini and Ed (abhijitkumbhare, 16:49:57) * Yi’s patch undoes some of the work by Srini & Ed (abhijitkumbhare, 16:50:26) * Yi’s patch modifies some of the existing extensions from Beryllium (abhijitkumbhare, 16:51:28) * LINK: https://git.opendaylight.org/gerrit/#/c/37937/ (vishnoianil, 16:56:04) Meeting ended at 17:00:25 UTC. Action items, by person ----------------------- * eshuvka_ * eshuvka_ to take a quick look at 5602; after that will likely need jbacigal to take over * hideyuki * hideyuki to take a look into 5692 if it can wait after the migration - since the estimate from Tomas Slusny for this M4 * jbacigal * eshuvka_ to take a quick look at 5602; after that will likely need jbacigal to take over * jbacigal looking into 4671 with michal_rehak
_______________________________________________ openflowplugin-dev mailing list openflowplugin-dev@lists.opendaylight.org https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev