Hi Icaro,
*-config modules are created for dependency injection (config-subsystem). In config module you usually define your module dependencies and provided service instances in config file. If your implementation is placed in some already defined module, you don't need to create new *-config module. Otherwise, in order to be able to get all needed dependencies (e.g. brokers, openflowjava, openflowplugin provider...) & connect with other components you need to create also the *-config module. Michal ________________________________ From: Icaro Camelo <icam...@inocybe.ca> Sent: 11 May 2016 16:32 To: Michal Polkoráb Cc: Rajasekaran, Monica; controller-...@lists.opendaylight.org; openflowplugin-dev@lists.opendaylight.org Subject: Re: [controller-dev] New OF message - Serialization and Deserialization Factories Hi Michal, I've implemented the Serializer/Deserializer, its respectives codecs and the CodecRegistration, but I'm confused with the wiring. I'm looking at the "openflowplugin-extension-nicira-config" module, but I'm not sure I need it. Am I missing something else? On Mon, May 9, 2016 at 6:56 AM, Michal Polkoráb <michal.polko...@pantheon.tech<mailto:michal.polko...@pantheon.tech>> wrote: Hi Icaro, please keep following the second link. If you experience any problems, share them or even update the wiki if you solve them. Michal ________________________________ From: Icaro Camelo <icam...@inocybe.ca<mailto:icam...@inocybe.ca>> Sent: 06 May 2016 22:28 To: Rajasekaran, Monica Cc: Michal Polkoráb; controller-...@lists.opendaylight.org<mailto:controller-...@lists.opendaylight.org>; openflowplugin-dev@lists.opendaylight.org<mailto:openflowplugin-dev@lists.opendaylight.org> Subject: Re: [controller-dev] New OF message - Serialization and Deserialization Factories Michal, Could you please tell me which wiki page (#1 or #2) is the most accurate to the Beryllium version? I'm following the link #2 and I'm getting Java type errors, since you told me that the augmentation type has changed since Lithium. 1. https://wiki.opendaylight.org/view/Openflow_Protocol_Library:Openflow_Protocol_Library's_extensibility:Basic_Principle_%26_Example 2. https://wiki.opendaylight.org/view/OpenDaylight_OpenFlow_Plugin:Architecture:Extensibility:Action On Fri, May 6, 2016 at 12:14 PM, Rajasekaran, Monica <monica.rajaseka...@us.fujitsu.com<mailto:monica.rajaseka...@us.fujitsu.com>> wrote: Hi Michal, Got it, I will do that. How does OFJava pick up my module that is defined separately ? Do I just import this module and corresponding augment into the newly created message factories under serialization & deserialization ? Thanks From: Michal Polkoráb [mailto:michal.polko...@pantheon.tech<mailto:michal.polko...@pantheon.tech>] Sent: Friday, May 06, 2016 2:53 AM To: Rajasekaran, Monica <monica.rajaseka...@us.fujitsu.com<mailto:monica.rajaseka...@us.fujitsu.com>> Cc: controller-...@lists.opendaylight.org<mailto:controller-...@lists.opendaylight.org>; openflowplugin-dev@lists.opendaylight.org<mailto:openflowplugin-dev@lists.opendaylight.org>; Icaro Camelo <icam...@inocybe.ca<mailto:icam...@inocybe.ca>> Subject: Re: [controller-dev] New OF message - Serialization and Deserialization Factories Hi Monica, you should create your own module just like Icaro in his example. Openflowjava provides only structures (model) defined in openflow (v1.0 & v1.3) specification - specific types should be defined in separate modules. Michal ________________________________ From: Rajasekaran, Monica <monica.rajaseka...@us.fujitsu.com<mailto:monica.rajaseka...@us.fujitsu.com>> Sent: 06 May 2016 04:01 To: Michal Polkoráb Cc: controller-...@lists.opendaylight.org<mailto:controller-...@lists.opendaylight.org>; openflowplugin-dev@lists.opendaylight.org<mailto:openflowplugin-dev@lists.opendaylight.org>; Icaro Camelo Subject: RE: [controller-dev] New OF message - Serialization and Deserialization Factories Hi Michal, Thanks for your reply. Okay, so in order to do the translation between MD-SAL and OFJava, I should add my own augment to “openflow-augments.yang” ? Or should I create a separate module for my message as done by Icaro ? I’m a newbie to ODL development, so please excuse me if the questions seem basic. Thanks, Monica From: Icaro Camelo [mailto:icam...@inocybe.ca] Sent: Wednesday, May 04, 2016 2:46 PM To: Michal Polkoráb <michal.polko...@pantheon.tech<mailto:michal.polko...@pantheon.tech>> Cc: Rajasekaran, Monica <monica.rajaseka...@us.fujitsu.com<mailto:monica.rajaseka...@us.fujitsu.com>>; controller-...@lists.opendaylight.org<mailto:controller-...@lists.opendaylight.org>; openflowplugin-dev@lists.opendaylight.org<mailto:openflowplugin-dev@lists.opendaylight.org> Subject: Re: [controller-dev] New OF message - Serialization and Deserialization Factories I have followed the aforementioned link and I'm getting an error about not finding the augmented target using the same yang file content: Here's my yang: http://pastebin.com/yhFtbBQw [ERROR] Failed to execute goal org.opendaylight.yangtools:yang-maven-plugin:1.0.0-SNAPSHOT:generate-sources (binding) on project of-extension-noviflow-api: yang-to-sources: Unable to parse yang files from /Users/icarocamelo/Development/inocybe/noviflow-plugin/of-extension-noviflow/of-extension-noviflow-api/src/main/yang: Augment target 'Absolute{path=[(urn:opendaylight:openflow:common:action?revision=2015-02-03)actions-container, (urn:opendaylight:openflow:common:action?revision=2015-02-03)action]}' not found [at META-INF/yang/of-extension-noviflow.yang:15:4] Could you please give some insight? On Wed, May 4, 2016 at 4:17 AM, Michal Polkoráb <michal.polko...@pantheon.tech<mailto:michal.polko...@pantheon.tech>> wrote: Hi Monica, the steps you have already done ensure only the translation between low level model (OFJava) and wire protocol. You also need to ensure translation between semantic high level model (MD-SAL) and protocol oriented low level model (OFJava). Please see this wiki page: https://wiki.opendaylight.org/view/OpenDaylight_OpenFlow_Plugin:Architecture:Extensibility for more information & also check *-extension-* modules in openflowplugin. The combination of openflowplugin code and wiki page should be enough for you to be able to finish your implementation. Michal ________________________________ From: Rajasekaran, Monica <monica.rajaseka...@us.fujitsu.com<mailto:monica.rajaseka...@us.fujitsu.com>> Sent: 03 May 2016 17:13 To: Michal Polkoráb; controller-...@lists.opendaylight.org<mailto:controller-...@lists.opendaylight.org>; openflowplugin-dev@lists.opendaylight.org<mailto:openflowplugin-dev@lists.opendaylight.org> Subject: RE: [controller-dev] New OF message - Serialization and Deserialization Factories Hi Michal, Thank you. Once I built that up, I added my new OF message’s details to openflow-protocol.yang which generated corresponding java files to generate my packet. And, I created message factories to handle the new message. Is this all in order to have a custom OF message up and running ? Note- The message itself has no special functionality. I am just doing this to understand message flow in the controller in order to develop further. Thanks From: Michal Polkoráb [mailto:michal.polko...@pantheon.tech<mailto:michal.polko...@pantheon.tech>] Sent: Tuesday, May 03, 2016 2:27 AM To: Rajasekaran, Monica <monica.rajaseka...@us.fujitsu.com<mailto:monica.rajaseka...@us.fujitsu.com>>; controller-...@lists.opendaylight.org<mailto:controller-...@lists.opendaylight.org>; openflowplugin-dev@lists.opendaylight.org<mailto:openflowplugin-dev@lists.opendaylight.org> Subject: Re: [controller-dev] New OF message - Serialization and Deserialization Factories Hello Monica, in order to create corresponding message factories you need to clone openflowjava (e.g. git clone ssh://{username}@git.opendaylight.org:29418/openflowjava<http://username...@git.opendaylight.org:29418/openflowjava>) and build it. Then you can replace your openflow-protocol-impl-0.7.1-Beryllium-SR1.jar with the new one. Regards, Michal Polkorab ________________________________ From: Rajasekaran, Monica <monica.rajaseka...@us.fujitsu.com<mailto:monica.rajaseka...@us.fujitsu.com>> Sent: 29 April 2016 17:35 To: controller-...@lists.opendaylight.org<mailto:controller-...@lists.opendaylight.org>; openflowplugin-dev@lists.opendaylight.org<mailto:openflowplugin-dev@lists.opendaylight.org> Subject: [controller-dev] New OF message - Serialization and Deserialization Factories Hi, As a part of trying to add a new OF message, I added the required definition to openflow-protocol.yang (which will in turn create the packet builder files). As far as I can understand, the next step looks like I should create corresponding message factories for serialization and deserialization. But, I am not able to find the correct way to do it. On Github, the java files are present at “openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/serialization/factories/”. I have Beryllium SR1 and that looks different. The path I have is: “/OPENDAYLIGHT/distribution-karaf-0.4.1-Beryllium-SR1/system/org/opendaylight/openflowjava/openflow-protocol-impl/0.7.1-Beryllium-SR1/openflow-protocol-impl-0.7.1-Beryllium-SR1.jar” Inside the jar file, there are a bunch of .class files. I do not see the java files here. Also, I do not see them present anywhere else. Any help on this? Thanks MichalPolkoráb Software Engineer Sídlo / Mlynské Nivy 56 / 821 05 Bratislava / Slovakia R&D centrum / Janka Kráľa 9 / 974 01 Banská Bystrica / Slovakia +421 918 378 907<tel:%2B421%20918%20378%20907> / michal.polko...@pantheon.tech<mailto:michal.polko...@pantheon.tech> reception: +421 2 206 65 114 / www.pantheon.sk<http://www.pantheon.sk> [logo] MichalPolkoráb Software Engineer Sídlo / Mlynské Nivy 56 / 821 05 Bratislava / Slovakia R&D centrum / Janka Kráľa 9 / 974 01 Banská Bystrica / Slovakia +421 918 378 907<tel:%2B421%20918%20378%20907> / michal.polko...@pantheon.tech<mailto:michal.polko...@pantheon.tech> reception: +421 2 206 65 114 / www.pantheon.sk<http://www.pantheon.sk> [logo] _______________________________________________ controller-dev mailing list controller-...@lists.opendaylight.org<mailto:controller-...@lists.opendaylight.org> https://lists.opendaylight.org/mailman/listinfo/controller-dev -- Thanks, Icaro Camelo Software Developer MichalPolkoráb Software Engineer Sídlo / Mlynské Nivy 56 / 821 05 Bratislava / Slovakia R&D centrum / Janka Kráľa 9 / 974 01 Banská Bystrica / Slovakia +421 918 378 907<tel:%2B421%20918%20378%20907> / michal.polko...@pantheon.tech<mailto:michal.polko...@pantheon.tech> reception: +421 2 206 65 114 / www.pantheon.sk<http://www.pantheon.sk> [logo] -- Thanks, Icaro Camelo Software Developer MichalPolkoráb Software Engineer Sídlo / Mlynské Nivy 56 / 821 05 Bratislava / Slovakia R&D centrum / Janka Kráľa 9 / 974 01 Banská Bystrica / Slovakia +421 918 378 907<tel:%2B421%20918%20378%20907> / michal.polko...@pantheon.tech reception: +421 2 206 65 114 / www.pantheon.sk<http://www.pantheon.sk> [logo] -- Thanks, Icaro Camelo Software Developer MichalPolkoráb Software Engineer Sídlo / Mlynské Nivy 56 / 821 05 Bratislava / Slovakia R&D centrum / Janka Kráľa 9 / 974 01 Banská Bystrica / Slovakia +421 918 378 907 / michal.polko...@pantheon.tech reception: +421 2 206 65 114 / www.pantheon.sk [logo]
_______________________________________________ openflowplugin-dev mailing list openflowplugin-dev@lists.opendaylight.org https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev
