Please see my response attached in this thread.
-Anandhi
From: Subhash Singh [mailto:subhash_si...@criterionnetworks.com]
Sent: Tuesday, May 24, 2016 1:48 PM
To: Thanh Ha <thanh...@linuxfoundation.org>
Cc: didm-...@lists.opendaylight.org; openflowplugin-dev
<openflowplugin-dev@lists.opendaylight.org>; nic-...@lists.opendaylight.org;
rele...@lists.opendaylight.org; Robert Varga <n...@hq.sk>; Manikantan, Anandhi
<anandhi.manikan...@hpe.com>
Subject: Re: [release] [openflowplugin-dev] [didm-dev] [nic-dev] OFP
getTableFeature() breakage in nic and didm
Hello Thanh Ha,
Yes I think OFP committers need to assist us to fix this issue.
Currently, the submitted patch [1] is not producing the response as expected by
DIDM.
@Anandhi,
Could you please add more clarity on it.
[1] https://git.opendaylight.org/gerrit/#/c/38507/
--
Regards,
Subhash Kumar Singh
On Wed, May 25, 2016 at 12:43 AM, Robert Varga <n...@hq.sk<mailto:n...@hq.sk>>
wrote:
On 05/24/2016 04:50 PM, Thanh Ha wrote:
> I believe NIC boron is also broke due to this same issue so adding them
> to this thread.
Yes, it has not published artifacts for a long time, those got purged
and now we cannot publish new ones via remerge.
Bye,
Robert
Input:
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<input xmlns="urn:opendaylight:params:xml:ns:yang:didm:drivers:openflow"
xmlns:opendaylight-inventory="urn:opendaylight:inventory">
<node>/opendaylight-inventory:nodes/opendaylight-inventory:node[opendaylight-inventory:id='openflow:673249119553088']</node>
<flow>
<match>
<ethernet-match>
<ethernet-type>
<type>2054</type>
</ethernet-type>
</ethernet-match>
</match>
<flags>SEND_FLOW_REM</flags>
<priority>0</priority>
<flow-name>ARP_FLOW</flow-name>
<instructions>
<instruction>
<order>0</order>
<apply-actions>
<action>
<order>0</order>
<output-action>
<output-node-connector>CONTROLLER</output-node-connector>
<max-length>65535</max-length>
</output-action>
</action>
<action>
<order>1</order>
<output-action>
<output-node-connector>NORMAL</output-node-connector>
<max-length>65535</max-length>
</output-action>
</action>
</apply-actions>
</instruction>
</instructions>
<idle-timeout>180</idle-timeout>
<hard-timeout>1800</hard-timeout>
<cookie>10</cookie>
</flow>
</input>
output:
{
"output": {
"flow": [
{
"strict": false,
"match": {
"ethernet-match": {
"ethernet-type": {
"type": 2054
}
}
},
"instructions": {
"instruction": [
{
"order": 0,
"apply-actions": {
"action": [
{
"order": 1,
"output-action": {
"output-node-connector": "NORMAL",
"max-length": 65535
}
},
{
"order": 0,
"output-action": {
"output-node-connector": "CONTROLLER",
"max-length": 65535
}
}
]
}
}
]
},
"flow-name": "ARP_FLOW",
"cookie": 10,
"flags": "SEND_FLOW_REM",
"hard-timeout": 1800,
"idle-timeout": 180,
"priority": 0,
"table_id": 0
},
{
"strict": false,
"match": {},
"instructions": {
"instruction": [
{
"order": 0,
"go-to-table": {
"table_id": 0
}
}
]
},
"flow-name": "ARP_FLOW",
"cookie": 10,
"flags": "SEND_FLOW_REM",
"hard-timeout": 1800,
"idle-timeout": 180,
"priority": 0,
"table_id": 100
}
]
}
}--- Begin Message ---
Since Subhash didn’t have HP switches, I’ve recreated the setup and tested
today.
I’m not getting the expected output with the changes made in the code review.
Since the methods are modified in openflow plugin, the adjust flow feature is
broken now in DIDM.
Attached please find the output for comparison.
Also, the instructions are missing in table 200.
Since I’m busy with other projects right now, won’t be able to spend much time.
But would be great if the oF plugin team can revise the changes and take action
accordingly.
Thanks
Anandhi
From: Abhijit Kumbhare [mailto:abhijitk...@gmail.com]
Sent: Monday, May 09, 2016 1:54 PM
To: Manikantan, Anandhi <anandhi.manikan...@hpe.com>
Cc: Subhash Singh <subhash_si...@criterionnetworks.com>; Thanh Ha
<thanh...@linuxfoundation.org>; openflowplugin-dev
<openflowplugin-dev@lists.opendaylight.org>; rele...@lists.opendaylight.org;
didm-...@lists.opendaylight.org
Subject: Re: [openflowplugin-dev] [release] [didm-dev] didm-hp module failing
to compile
Thanks Alexis & Anandhi!
On Mon, May 9, 2016 at 1:37 PM, Manikantan, Anandhi
<anandhi.manikan...@hpe.com<mailto:anandhi.manikan...@hpe.com>> wrote:
Hi Subhash,
I reviewed the code and comments. Alex has responded to the comments and
feels that this needs to be tested before merge.
Since I don’t have the setup now, would you be able to test and let me know
so that I can merge.
I can help you with test guidelines if needed
Please shoot me an e-mail offline.
Thanks
Anandhi
From: Subhash Singh
[mailto:subhash_si...@criterionnetworks.com<mailto:subhash_si...@criterionnetworks.com>]
Sent: Friday, May 06, 2016 8:08 AM
To: Manikantan, Anandhi
<anandhi.manikan...@hpe.com<mailto:anandhi.manikan...@hpe.com>>
Cc: Alexis de Talhouët
<adetalho...@inocybe.com<mailto:adetalho...@inocybe.com>>; Jamo Luhrsen
<jluhr...@gmail.com<mailto:jluhr...@gmail.com>>;
rele...@lists.opendaylight.org<mailto:rele...@lists.opendaylight.org>;
didm-...@lists.opendaylight.org<mailto:didm-...@lists.opendaylight.org>;
openflowplugin-dev
<openflowplugin-dev@lists.opendaylight.org<mailto:openflowplugin-dev@lists.opendaylight.org>>;
Thanh Ha <thanh...@linuxfoundation.org<mailto:thanh...@linuxfoundation.org>>
Subject: Re: [release] [didm-dev] didm-hp module failing to compile
Hello Anandhi,
Could you please review the patch, as you are more familiar with this part
of the implementation and also I don't have the rights to merge.
--
Thanks and Regards,
Subhash Kumar Singh
On Fri, May 6, 2016 at 7:27 PM, Thanh Ha
<thanh...@linuxfoundation.org<mailto:thanh...@linuxfoundation.org>> wrote:
Thanks Alexis,
Can someone review and merge the patch?
Thanks,
Thanh
On 6 May 2016 at 08:45, Alexis de Talhouët
<adetalho...@inocybe.com<mailto:adetalho...@inocybe.com>> wrote:
And the candidate fix:
https://git.opendaylight.org/gerrit/#/c/38507/
Thanks,
Alexis
On May 6, 2016, at 8:21 AM, Alexis de Talhouët
<adetalho...@inocybe.com<mailto:adetalho...@inocybe.com>> wrote:
FYI, this is the reason one DIDM is broken: changed of OFP yang
model:
https://git.opendaylight.org/gerrit/#/c/36559/5/model/model-flow-service/src/main/yang/flow-node-inventory.yang
Thanks,
Alexis
On May 5, 2016, at 8:03 PM, Thanh Ha
<thanh...@linuxfoundation.org<mailto:thanh...@linuxfoundation.org>> wrote:
FYI we've disabled DIDM from autorelease-boron so that the job
can continue testing until this bug is sorted out.
Regards,
Thanh
On 5 May 2016 at 16:39, Thanh Ha
<thanh...@linuxfoundation.org<mailto:thanh...@linuxfoundation.org>> wrote:
To be clear it's the root cause of why we can't reproduce the
failure locally since ofp hasn't been pushing to Nexus their latest artifacts.
didm-hp will still fail to compile so we still need someone
to look into why getTableFeature() is failing.
Regards,
Thanh
On 5 May 2016 at 15:11, Jamo Luhrsen
<jluhr...@gmail.com<mailto:jluhr...@gmail.com>> wrote:
after more debugging with Thanh, we think the root cause
is because openflowplugin's
merge job started failing because of the http vs https
issue when uploading artifacts
to nexus.
this patch in openflowplugin should fix that:
https://git.opendaylight.org/gerrit/38436
JamO
On 05/05/2016 11:38 AM, Subhash Singh wrote:
> +[Anandhi]
>
> Hello Thanh,
>
> Anandhi is familiar with didm-hp module (using
getTableFeature), I think she could add clarification on this issue.
>
> --
> Regards,
> Subhash Kumar Singh
>
> On Thu, May 5, 2016 at 11:46 PM, Thanh Ha
<thanh...@linuxfoundation.org<mailto:thanh...@linuxfoundation.org>
<mailto:thanh...@linuxfoundation.org<mailto:thanh...@linuxfoundation.org>>>
wrote:
>
> On 5 May 2016 at 00:31, Thanh Ha
<thanh...@linuxfoundation.org<mailto:thanh...@linuxfoundation.org>
<mailto:thanh...@linuxfoundation.org<mailto:thanh...@linuxfoundation.org>>>
wrote:
>
> Hi didm-devs,
>
> Autorelease has been failing since April 27th
due to didm-hp module failing to compile due to some unresolvable symbols
(missing or changed
> dependencies?). Can someone take a look?
>
> I opened bug 5843 to track this issue [0].
>
> Regards,
> Thanh
>
> [0]
https://bugs.opendaylight.org/show_bug.cgi?id=5843
>
>
>
> Hi Everyone,
>
> So taking a look at this closer with Jamo just now.
We noticed that this patch [0] in openflowplugin removed something that sounds
like
> getTableFeatures() but I'm not at all familiar with
how yang maps to Java so I could be wrong but could this be the cause of
getTableFeatures()
> being missing?
>
> If so how do we fix this?
>
> Regards,
> Thanh
>
> [0]
https://git.opendaylight.org/gerrit/#/c/36559/5/model/model-flow-statistics/src/main/yang/opendaylight-flow-table-statistics.yang
>
> _______________________________________________
> didm-dev mailing list
>
didm-...@lists.opendaylight.org<mailto:didm-...@lists.opendaylight.org>
<mailto:didm-...@lists.opendaylight.org<mailto:didm-...@lists.opendaylight.org>>
>
https://lists.opendaylight.org/mailman/listinfo/didm-dev
>
>
>
>
> _______________________________________________
> release mailing list
>
rele...@lists.opendaylight.org<mailto:rele...@lists.opendaylight.org>
> https://lists.opendaylight.org/mailman/listinfo/release
>
_______________________________________________
release mailing list
rele...@lists.opendaylight.org<mailto:rele...@lists.opendaylight.org>
https://lists.opendaylight.org/mailman/listinfo/release
_______________________________________________
openflowplugin-dev mailing list
openflowplugin-dev@lists.opendaylight.org<mailto:openflowplugin-dev@lists.opendaylight.org>
https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev
Input:
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<input xmlns="urn:opendaylight:params:xml:ns:yang:didm:drivers:openflow"
xmlns:opendaylight-inventory="urn:opendaylight:inventory">
<node>/opendaylight-inventory:nodes/opendaylight-inventory:node[opendaylight-inventory:id='openflow:673249119553088']</node>
<flow>
<match>
<ethernet-match>
<ethernet-type>
<type>2054</type>
</ethernet-type>
</ethernet-match>
</match>
<flags>SEND_FLOW_REM</flags>
<priority>0</priority>
<flow-name>ARP_FLOW</flow-name>
<instructions>
<instruction>
<order>0</order>
<apply-actions>
<action>
<order>0</order>
<output-action>
<output-node-connector>CONTROLLER</output-node-connector>
<max-length>65535</max-length>
</output-action>
</action>
<action>
<order>1</order>
<output-action>
<output-node-connector>NORMAL</output-node-connector>
<max-length>65535</max-length>
</output-action>
</action>
</apply-actions>
</instruction>
</instructions>
<idle-timeout>180</idle-timeout>
<hard-timeout>1800</hard-timeout>
<cookie>10</cookie>
</flow>
</input>
Output:
{
"output": {
"flow": [
{
"idle-timeout": 180,
"instructions": {
"instruction": [
{
"order": 0,
"apply-actions": {
"action": [
{
"order": 1,
"output-action": {
"output-node-connector": "NORMAL",
"max-length": 65535
}
},
{
"order": 0,
"output-action": {
"output-node-connector": "CONTROLLER",
"max-length": 65535
}
}
]
}
}
]
},
"strict": false,
"table_id": 200,
"flags": "SEND_FLOW_REM",
"cookie": 10,
"hard-timeout": 1800,
"match": {
"ethernet-match": {
"ethernet-type": {
"type": 2054
}
}
},
"flow-name": "ARP_FLOW",
"priority": 0
},
{
"idle-timeout": 180,
"instructions": {
"instruction": [
{
"order": 0,
"go-to-table": {
"table_id": 200
}
}
]
},
"strict": false,
"table_id": 100,
"flags": "SEND_FLOW_REM",
"cookie": 10,
"hard-timeout": 1800,
"match": {},
"flow-name": "ARP_FLOW",
"priority": 0
}
]
}
}
--- End Message ---
_______________________________________________
openflowplugin-dev mailing list
openflowplugin-dev@lists.opendaylight.org
https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev
