Great - thanks! On Wed, Jul 20, 2016 at 12:15 PM, Jozef Bacigal -X (jbacigal - PANTHEON TECHNOLOGIES at Cisco) <jbaci...@cisco.com> wrote:
> Already merged with "false" by default > > > Jozef > ------------------------------ > *From:* openflowplugin-dev-boun...@lists.opendaylight.org < > openflowplugin-dev-boun...@lists.opendaylight.org> on behalf of Tai, > Hideyuki <hideyuki....@necam.com> > *Sent:* Tuesday, July 19, 2016 7:06 PM > *To:* Anil Vishnoi; Miroslav Macko; Shuva Jyoti Kar; Abhijit Kumbhare; > openflowplugin-dev@lists.opendaylight.org > > *Subject:* Re: [openflowplugin-dev] Bug 5539 - Remove deprecated model > > > +1 to making notification-flow-removed-off *false* by default. > > > > Regards, > > Hideyuki Tai > > > > *From:* Anil Vishnoi [mailto:vishnoia...@gmail.com] > *Sent:* Monday, July 18, 2016 19:59 > *To:* Miroslav Macko <miroslav.ma...@pantheon.tech> > *Cc:* Shuva Jyoti Kar <shuva.jyoti....@ericsson.com>; Abhijit Kumbhare < > abhijitk...@gmail.com>; Tai, Hideyuki <hideyuki....@necam.com>; > openflowplugin-dev@lists.opendaylight.org > *Subject:* Re: [openflowplugin-dev] Bug 5539 - Remove deprecated model > > > > Hi All, > > > > In my personal opinion, notification-flow-removed-off should be false by > default. Because commonly most of the application look for the functional > aspect and then performance aspect. Disabling flow removal event is like > disabling the functionality and some of the application might not even work > with that. Given that there are application already exist in OpenDaylight > that requires it, we should enable it by default. Ideally we should enable > all the functionality by default rather than disabling them, and have a > wiki page that describes about the flag that can help get the best > performance out of the plugin. > > > > On Mon, Jul 18, 2016 at 6:04 AM, Miroslav Macko < > miroslav.ma...@pantheon.tech> wrote: > > Hi guys, > > > > We have created switch for turn off flow removed notification. Default > will be true and notification will be turned off. > > > > @Shuva - It will be possible to change it at "runtime". It is possible by > adding "org.opendaylight.openflowplugin.cfg" configuration file to karaf > etc folder. > > > > There is possible to set property notification-flow-removed-off: > > > > notification-flow-removed-off=true - notification is not send > > notification-flow-removed-off=false - notification is send > > > > Example of the config file is in the attachment. > > > > I am currently still working on generating of the configuration file > org.opendaylight.openflowplugin.cfg automatically, when feature is > installed. > > > > Thanks, > > Miro > > > > > ------------------------------ > > *Od:* Shuva Jyoti Kar <shuva.jyoti....@ericsson.com> > *Odoslané:* 1. júla 2016 4:39 > *Komu:* Abhijit Kumbhare; Tai, Hideyuki > *Kópia:* Miroslav Macko; openflowplugin-dev@lists.opendaylight.org > *Predmet:* RE: [openflowplugin-dev] Bug 5539 - Remove deprecated model > > > > Given that we have agreed to go for a knob in CARBON, perhaps as a > work-item it would be great if we could come up with the list of > notifications that the applications require or use as of today, > flow_removed being one such. If there are no applications/users using > particular notification(s) , I do agree with Miroslav’s point of “cleaning > up the api(s)” to remove the unused ones. > > > > *From:* Abhijit Kumbhare [mailto:abhijitk...@gmail.com] > *Sent:* Thursday, June 30, 2016 11:53 PM > *To:* Tai, Hideyuki > *Cc:* Shuva Jyoti Kar; Miroslav Macko; > openflowplugin-dev@lists.opendaylight.org > *Subject:* Re: [openflowplugin-dev] Bug 5539 - Remove deprecated model > > > > We agreed in the meeting that it should not be deprecated and a knob > should be provided to enable/disable notification as well as applications > should be able to turn on specific notifications by subscribing to them. > > > > On Thu, Jun 30, 2016 at 10:27 AM, Tai, Hideyuki <hideyuki....@necam.com> > wrote: > > Hi, > > > > I couldn't attend the today's meeting, but read the meeting minutes. > > > > I think we should merge the following patch. > > https://git.opendaylight.org/gerrit/#/c/39552/ > > The flow-removed notification should be supported in Boron, unless the > OpenFlow plugin provides another way to deal with the bug 5602. > > > > The bug 5602 is an issue. > > In Boron, the only way OpenFlow plugin provides for the bug 5602 is the > flow-removed notification as of now. > > So some applications need to use the flow-removed in Boron, the > applications do not have any other choice. > > > > So if OpenFlow plugin provides alternative way for the bug 5602 in Boron, > I'm ok with making the flow-removed notification deprecated in Boron. > > My point is that the only way to deal with a problem should be supported, > and should not be marked as deprecated. > > > > Of course, I'm ok that if the OpenFlow Plugin provides a better > alternative way to deal with the bug 5602 in Carbon, we mark the > flow-removed notification as deprecated in Carbon. > > > > Please note that the Helium design of OpenFlow plugin does not have this > issue (Bug 5602). > > Therefore, I think Beryllium users do not expect to face the issue in > Boron, so we should provide a supported way to deal with the bug 5602 in > Boron. > > > > Regards, > > Hideyuki Tai > > > > *From:* openflowplugin-dev-boun...@lists.opendaylight.org [mailto: > openflowplugin-dev-boun...@lists.opendaylight.org] *On Behalf Of *Shuva > Jyoti Kar > *Sent:* Thursday, June 30, 2016 07:08 > *To:* Miroslav Macko <miroslav.ma...@pantheon.tech>; > openflowplugin-dev@lists.opendaylight.org > *Subject:* Re: [openflowplugin-dev] Bug 5539 - Remove deprecated model > > > > Sure lets discuss this , since for applications that are using these > notifications , they would require the same guarantees. > > > > Thanks > > Shuva > > > > *From:* openflowplugin-dev-boun...@lists.opendaylight.org [mailto: > openflowplugin-dev-boun...@lists.opendaylight.org] *On Behalf Of *Miroslav > Macko > *Sent:* Thursday, June 30, 2016 7:14 PM > *To:* openflowplugin-dev@lists.opendaylight.org > *Subject:* [openflowplugin-dev] Bug 5539 - Remove deprecated model > > > > Hi guys, > > > > We would like to discuss Bug 5539 Remove Deprecated model > https://bugs.opendaylight.org/show_bug.cgi?id=5539 > > > > If it is possible we can take it on Community meeting. Please feel > free add also your comments. > > > > Thank you, > Miro > > > > Miroslav*Macko* > > Software Developer > > > Sídlo / Mlynské Nivy 56 / 821 05 Bratislava / Slovakia > R&D centrum / Janka Kráľa 9 / 974 01 Banská Bystrica / Slovakia > / miroslav.ma...@pantheon.tech > reception: +421 2 206 65 114 / www.pantheon.sk > > [image: Image removed by sender. logo] > > > > > _______________________________________________ > openflowplugin-dev mailing list > openflowplugin-dev@lists.opendaylight.org > https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev > > > > Miroslav*Macko* > > Software Developer > > > Sídlo / Mlynské Nivy 56 / 821 05 Bratislava / Slovakia > R&D centrum / Janka Kráľa 9 / 974 01 Banská Bystrica / Slovakia > / miroslav.ma...@pantheon.tech > reception: +421 2 206 65 114 / www.pantheon.sk > > [image: Image removed by sender. logo] > > > > > _______________________________________________ > openflowplugin-dev mailing list > openflowplugin-dev@lists.opendaylight.org > https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev > > > > > > -- > > Thanks > > Anil >
_______________________________________________ openflowplugin-dev mailing list openflowplugin-dev@lists.opendaylight.org https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev
