Thanks everyone, I merged it in Carbon branch to unblock our version bumping efforts and cherry-picked it to stable/boron.
Subhash, Can you merge the stable/boron patch? https://git.opendaylight.org/gerrit/43545 Thanks, Thanh On Tue, Aug 9, 2016 at 1:42 PM, Subhash Singh < [email protected]> wrote: > Hello Anil, > > Thanks for the clarification. > I will discuss the same with Anandhi to fix the use of non exposed API > from OpenFlowPlugin. > > -- > Thanks and Regards, > Subhash Kumar Singh > > On Tue, Aug 9, 2016 at 11:01 PM, Anil Vishnoi <[email protected]> > wrote: > >> I pushed the following patch to DIDM and it should fix their compilation >> errors. >> >> https://git.opendaylight.org/gerrit/#/c/43537/ >> >> DIDM project, please DO NOT USE the openflowpligin MatchConvertor classes >> for conversion in your project. These classes are not official interface >> for downstream projects to consume. These classes can be refactored as well >> and that will break your project. >> >> Abhijit, can you please put this on openflowplugin todo list. We should >> not be exposing these classes to downstream projects. >> >> Thanks >> Anil >> >> On Tue, Aug 9, 2016 at 10:19 AM, Anil Vishnoi <[email protected]> >> wrote: >> >>> At a quick looks it's not caused by TCP Flags API change. TCP Flags >>> related fix was already pushed with the following patch to didm project and >>> merged with successful distribution job. >>> >>> https://git.opendaylight.org/gerrit/#/c/43086/ >>> >>> This failure is because of the new change around the match convertor >>> code in openflowplugin pushed by Tomas. >>> >>> https://git.opendaylight.org/gerrit/#/c/40877/23 >>> >>> I am looking at it, will push a patch soon. >>> >>> Thanks >>> Anil >>> >>> On Tue, Aug 9, 2016 at 8:55 AM, An Ho <[email protected]> wrote: >>> >>>> Hi Anil, >>>> >>>> Any chance you could help the DIDM folks with issues related to the >>>> Openflow plugin TCP Flags API change? >>>> >>>> Best Regards, >>>> An Ho >>>> >>>> -----Original Message----- >>>> From: [email protected] [mailto: >>>> [email protected]] On Behalf Of Robert Varga >>>> Sent: Tuesday, August 09, 2016 8:01 AM >>>> To: Thanh Ha; [email protected]; >>>> [email protected] >>>> Subject: Re: [release] didm-hp compilation failure in autorelease-boron >>>> >>>> >>>> >>>> On 08/09/2016 03:52 PM, Thanh Ha wrote: >>>> > Has anyone had a chance to look at this? >>>> > >>>> > It turns out this is blocking version bump efforts now because didm is >>>> > not in a mergeable state at the moment. >>>> >>>> Looks like fallout another fallout from Anil's flag change... >>>> >>>> Bye, >>>> Robert >>>> >>>> >>> >>> >>> -- >>> Thanks >>> Anil >>> >> >> >> >> -- >> Thanks >> Anil >> >> _______________________________________________ >> didm-dev mailing list >> [email protected] >> https://lists.opendaylight.org/mailman/listinfo/didm-dev >> >> >
_______________________________________________ openflowplugin-dev mailing list [email protected] https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev
