Anyone knows how to fix odl-interface-rpc.yang with minimal changes so that this serialization issue goes off? I have taken a look, I cannot see an easy way without adding all augmentations, and then using ActionConverterUtil.java in all applications using this RPC to convert them back.
Thanks, Faseela -----Original Message----- From: Jaime Caamaño Ruiz [mailto:jcaam...@suse.de] Sent: Tuesday, July 10, 2018 3:27 PM To: Tom Pantelis <tompante...@gmail.com>; Deepthi V V <deepthi....@ericsson.com> Cc: Faseela K <faseel...@ericsson.com>; Robert Varga <n...@hq.sk>; genius-...@lists.opendaylight.org; mdsal-...@lists.opendaylight.org; openflowplugin-dev@lists.opendaylight.org; sfc-...@lists.opendaylight.org; Vishal Thapar <vtha...@redhat.com> Subject: Re: [sfc-dev] [openflowplugin-dev] [mdsal-dev] IncorrectNestingException on SFC when sing OFP model Hello Tom, Robert > However the serialization bypass was "broken" in the process. I think > this explains the difference. Are patches [1] and [2] intention to restore this bypass? I tested [3] a multipatch build [4] with both patches and still get the IncorrectNestingException. BR Jaime. [1] https://git.opendaylight.org/gerrit/#/c/73824/ [2] https://git.opendaylight.org/gerrit/#/c/73825/ [3] https://jenkins.opendaylight.org/sandbox/job/netvirt-csit-1node-openstack-queens-sfc-fluorine/1/ [4] https://jenkins.opendaylight.org/releng/job/integration-multipatch-test-fluorine/160 -----Original Message----- From: Tom Pantelis <tompante...@gmail.com> To: Deepthi V V <deepthi....@ericsson.com>, jcaam...@suse.de Cc: Faseela K <faseel...@ericsson.com>, Robert Varga <n...@hq.sk>, genius-...@lists.opendaylight.org <genius-...@lists.opendaylight.org>, mdsal-...@lists.opendaylight.org <mdsal-...@lists.opendaylight.org>, openflowplugin-dev@lists.opendaylight.org <openflowplugin-...@lists.ope ndaylight.org>, sfc-...@lists.opendaylight.org <sfc-dev@lists.opendayli ght.org>, Vishal Thapar <vtha...@redhat.com> Subject: Re: [sfc-dev] [openflowplugin-dev] [mdsal-dev] IncorrectNestingException on SFC when sing OFP model Date: Mon, 9 Jul 2018 14:10:48 -0400 On Mon, Jul 9, 2018 at 1:41 PM, Tom Pantelis <tompante...@gmail.com> wrote: > > On Mon, Jul 9, 2018 at 6:29 AM, Deepthi V V <deepthi....@ericsson.com > > wrote: > > Hi Robert, Faseela, > > > > That does explain our situation. > > But doesn't the blueprint extensions odl:rpc-implementation and > > odl:rpc-service supposed to register and fetch the service through > > RPC-registry? > > These were recently changed to use the mdsal APIs. > netvirt uses the blueprint RPC ext which have been converted to use the mdsal APIs so the serialization bypass that Robert mentioned takes effect and masks the underlying app-side issue. sfc uses the controller RpcProviderRegistry API whose DOM impls were recently changed to proxy to the mdsal APIs. However the serialization bypass was "broken" in the process. I think this explains the difference. > > > Thanks, > > Deepthi > > > > -----Original Message----- > > From: Robert Varga <n...@hq.sk> > > Sent: Monday, July 09, 2018 3:36 PM > > To: Faseela K <faseel...@ericsson.com>; Deepthi V V <deepthi.v.v@er > > icsson.com>; Vishal Thapar <vtha...@redhat.com> > > Cc: sfc-...@lists.opendaylight.org; mdsal-...@lists.opendaylight.or > > g; genius-...@lists.opendaylight.org; Tom Pantelis <tompantelis@gma > > il.com>; openflowplugin-dev@lists.opendaylight.org > > Subject: Re: [openflowplugin-dev] [mdsal-dev] > > IncorrectNestingException on SFC when sing OFP model > > > > On 09/07/18 11:55, Faseela K wrote: > > > Netvirt uses blueprint wiring and injects the > > odlInterfaceRpcService, > > > where as sfc uses interfaceManagerRpcService = > > > rpcProviderRegistry.getRpcService(OdlInterfaceRpcService.class); > > > > > > Robert indicated that so netvirt is bypassing MD-SAL, as it is > > taking the service implementation from OSGi Service Registry, and > > that explains why the failure is happening only for sfc. > > > > Correct. > > > > Note that netvirt approach requires the service to be local, whereas > > the SFC approach is location agnostic (the service can be located > > anywhere in the cluster). > > > > Regards, > > Robert > > _______________________________________________ sfc-dev mailing list sfc-...@lists.opendaylight.org https://lists.opendaylight.org/mailman/listinfo/sfc-dev _______________________________________________ openflowplugin-dev mailing list openflowplugin-dev@lists.opendaylight.org https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev
