Great job guys, looks awesome :)
such optimizations would be needed for other analyzers as well ...
e.g. in one of the Dougs pictures there were other analyzers taking up a
lot of memory too ...
thank you!
Lubos
On 2.7.2011 10:06, [email protected] wrote:
https://defect.opensolaris.org/bz/show_bug.cgi?id=18602
Knut Anders Hatlen<[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |CLOSED
Resolution| |FIXED
AssignedTo|[email protected] |[email protected]
Target Milestone|--- |next
--- Comment #27 from Knut Anders Hatlen<[email protected]> 2011-07-02
08:06:11 UTC ---
I pushed one small additional change in changeset: 1266:288c9e59a77e
This change made JavaClassAnalyzer use ArrayLists instead of LinkedLists,
because LinkedLists are not very compact, and the lists can get pretty large
when analyzing big jar files. It also made JarAnalyzer store the xref fragments
generated for the individual class files in a list instead of in a big buffer,
so that we don't need two copies of the xref in memory.
With this latest change, I managed to index the jar file in my test case with
-Xmx365M, which is ~60% lower than the 900 MB I had to start with. I hope this
is sufficient for now, so I'm closing the bug as fixed.
There may be more optimizations we could make, but now at least the OOME is
shown, thanks to the changes Jens made in bug #18618, so the users get a hint
that turning up the memory settings might help.
_______________________________________________
opengrok-dev mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/opengrok-dev
