Thank you Jan

the patch looks good, however without the web service it doesn't make much sense to integrate it yet
to make the url configurable is not a big deal,
basically http://src.opensolaris.org/source/xref/opengrok/trunk/src/org/opensolaris/opengrok/configuration/
make up the configuration.xml (configuration object is written down as xml)

and http://src.opensolaris.org/source/xref/opengrok/trunk/src/org/opensolaris/opengrok/index/Indexer.java#147 makes up the cmdline options ( http://src.opensolaris.org/source/xref/opengrok/trunk/src/org/opensolaris/opengrok/index/CommandLineOptions.java )

I was also thinking about some way how to extend an IDE in a terms that it would query the opengrok as it is ... e.g. if you look at the greasemonkey script - it already does use the search capability and xml conformance of opengrok - so I think it could be extended also in this way - not only by passing on the path to file I am quite sure Eclipse could query opengrok this way and as you say, you could send the pointer from opengrok to Eclipse too with (maybe slight modification) of your patch (even directly, no? )

cheers
L

On 14.9.2011 16:10, Jan Keirse wrote:

Lubos Kosco <[email protected]> schreef op 13/09/2011 11:21:55:

> On 13.9.2011 11:11, Jan Keirse wrote:
> >   Lubos Kosco<[email protected]>  schreef op 09/09/2011 23:43:38:
> >
> >> Great stuff Jan!
> >>
> >> I am already looking forward to see the patch for this feature upstream > >> - I think some people already asked about support of IDEs from opengrok
> > ...
> >
> > Right now I have just hard-coded a non configureable link, I'll see if I
> > can get this configureable in the WEB-INF/web.xml file.
> > To support it in an IDE you'd either have to make a plugin for the IDE
> > that listens to a JMS queue and have opengrok connect to a webservice that > > sends a message to that queue, or (I think better for over the web use) > > sets up a simple webserver (ie on localhost:8088) and make the opengrok > > website sent requests directly to that agreed-upon port (from the client
> > webbrowser, without the opengrok webserver even knowing.)
>
> if you can write it down into a readme and send a patch, which automates
> as much as it can I would gladly accept it
> this would be a nice feature - e.g. I use mostly netbeans and its
> symbol/definition search is sometimes SO SLOW (the unfamous "scanning
> projects" running - ide unusable :( ), so I would really be happy to
> have such feature as an addon to standard IDE features

Hello Lubos,

I've got it working but it's hard coded:



What I would like to make it universally usefull is to allow the URL's for the Integration to come from the configuration.xml file, but I haven't found the time to look into that yet (and I've been coding Java only a few days every few years ;-))

Sadly the current implementation of the webserver that gets the requests is only usefull for TVH (because it relies on a highly customized and obsolete IDE.) We will probably going to (or better, I hope to) write a plugin for Eclipse in about a year (we're going to switch) if it doesn't exist yet by that time.

Kind Regards,
*
JAN KEIRSE*
ICT-DEPARTMENT
Software quality & Systems: Software Engineer
**** DISCLAIMER ****

http://www.tvh.com/newen2/emaildisclaimer/default.html

"This message is delivered to all addressees subject to the conditions
set forth in the attached disclaimer, which is an integral part of this
message."

# This patch file was generated by NetBeans IDE
# Following Index: paths are relative to: C:\ws\opengrok
# This patch can be applied using context Tools: Patch action on respective 
folder.
# It uses platform neutral UTF-8 encoding and \n newlines.
# Above lines and this line are ignored by the patching process.
Index: build.xml
--- build.xml Base (BASE)
+++ build.xml Locally Modified (Based On LOCAL)
@@ -123,6 +123,7 @@
         <pathelement path="${java.class.path}"/>
         <pathelement path="lib"/>
         <pathelement path="../lib"/>
+        <pathelement path="lib/JFlex.jar"/>
     </path>
 
     <path id="findbugs.lib.search.path">
Index: nbproject/project.properties
--- nbproject/project.properties Base (BASE)
+++ nbproject/project.properties Locally Modified (Based On LOCAL)
@@ -34,6 +34,7 @@
 excludes=
 file.reference.ant.jar=${ant.library.dir}/ant.jar
 file.reference.bcel-5.2.jar=lib/bcel-5.2.jar
+file.reference.JFlex.jar=lib\\JFlex.jar
 file.reference.lucene-core-3.0.2.jar=lib/lucene-core-3.0.2.jar
 file.reference.lucene-spellchecker-3.0.2.jar=lib/lucene-spellchecker-3.0.2.jar
 file.reference.jrcs.jar=lib/jrcs.jar
@@ -48,7 +49,8 @@
     ${file.reference.servlet-api.jar}:\
     ${file.reference.swing-layout-0.9.jar}:\
     ${file.reference.lucene-core-3.0.2.jar}:\
-    ${file.reference.lucene-spellchecker-3.0.2.jar}
+    ${file.reference.lucene-spellchecker-3.0.2.jar}:\
+    ${file.reference.JFlex.jar}
  
 # Space-separated list of extra javac options
 javac.compilerargs=-Xlint:unchecked
Index: src/org/opensolaris/opengrok/search/Results.java
--- src/org/opensolaris/opengrok/search/Results.java Base (BASE)
+++ src/org/opensolaris/opengrok/search/Results.java Locally Modified (Based On 
LOCAL)
@@ -56,6 +56,7 @@
  * @author Chandan slightly rewritten by Lubos Kosco
  */
 public final class Results {
+    private static String appBuilderStarter = 
"http://be-plw-wks-0191/cgi-bin/cgiip.exe/WService=appb/compserv/popeninab.p?"; ;
     private Results() {
         // Util class, should not be constructed
     }
@@ -188,6 +189,18 @@
                 out.write(rawPrefixE);
                 out.write(rpathE);
                 out.write("\" title=\"Download\">D</a>");
+                out.write("<div class=\"integration\">&nbsp;I <div 
class=\"extentions\">Integration<BR />");
+                out.write(" <a href=\""
+                        + appBuilderStarter
+                        + "environment=dev&path="
+                        + rpathE
+                        + "\">Open In Dev AppBuilder</a><BR />");
+                out.write(" <a href=\""
+                        + appBuilderStarter
+                        + "environment=prod&path="
+                        + rpathE
+                        + "\">Open In Prod AppBuilder</a>");
+                out.write("</div></div>");
                 out.write("</td>");
                 out.write("<td class=\"f\"><a href=\"");
                 out.write(xrefPrefixE);
_______________________________________________
opengrok-dev mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/opengrok-dev

Reply via email to