https://defect.opensolaris.org/bz/show_bug.cgi?id=19108

Knut Anders Hatlen <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CAUSEKNOWN
                 CC|                            |[email protected]

--- Comment #1 from Knut Anders Hatlen <[email protected]> 2011-12-16 
10:39:45 UTC ---
The problem here is that the minus in <<-EOF means that leading tabs should be
stripped away. ShXref knows that it should strip away leading tabs in this
case, so even if the line with the last EOF has leading tabs, it knows that
it's the stop word. However, if the project is configured with a tabSize
setting, we'll expand tabs to spaces before generating the xref. Since leading
spaces before the stop word should not be stripped out, ShXref doesn't
recognize the stop word, and the rest of the script will be rendered as if it
was part of the heredoc.

In the default project configuration, this should not be an issue, because no
custom tab size should be set. In 0.11rc this has changed though.
Unintentionally, I guess. Now Configuration's constructor calls:

        setTabSize(4);

The immediate fix for this problem is to remove that call from the constructor
so that the default tab size is reverted to unspecified.

Even with that fix, the problem will still be seen in projects that have
explicitly set a custom tab size. It would be better if we could preserve the
tabs and instead make the style sheets take care of rendering them correctly. I
don't think HTML/CSS has a good solution for this currently (looks like
tab-size is planned for CSS 3:
http://www.w3.org/TR/2011/WD-css3-text-20110901/#tab-size).

-- 
Configure bugmail: https://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
opengrok-dev mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/opengrok-dev

Reply via email to