On Tue, Mar 27, 2012 at 12:57:59AM -0400, Haehn, Steven wrote: Hi Steven, > Thanks for the input. I tried looking for <span class="blame"...> in the web > code before
The "starting point is" http://src.opensolaris.org/source/xref/opengrok/trunk/src/org/opensolaris/opengrok/analysis/JFlexXref.java#299 and than goes to http://src.opensolaris.org/source/xref/opengrok/trunk/src/org/opensolaris/opengrok/web/Util.java#465 or a little bit more compact: http://src.iws.cs.ovgu.de/source/xref/opengrok-jel/src/org/opensolaris/opengrok/analysis/JFlexXref.java#startNewLine and than scroll up ... > I posted my first note and when I did not find it, all I could think is that > the opensolaris site has newer software. No - this site seems to use v0.9 > Since I am writing a new repository (for AccuRev), I was trying to see if > what was presented at the OpenSolaris site was new or not. You have indicated > that the feature was old, so there may be something that I am missing in my > repository code, but I am not sure what. Hmmm, someone reported to have problems with file based history. So using JDBC based history might be worth to try. Also have a look at your server (tomcat?) log files ... > I have figured out that I need to add a versioning portion to the annotate > method in my repository. The other thing I had to do was get rid of the extra > spaces around the version/revision string. I'm a little bit irritated. You said, you are using mercurial? This doesn't work out of the box? http://src.opensolaris.org/source/xref/opengrok/trunk/src/org/opensolaris/opengrok/history/MercurialRepository.java shows, what it actually does to get the history/commit messages... > I was using that for padding to get better spacing in the browser display > because the version numbers and author column are getting all jammed together > making it hard to read. Old browser (which, which version, which style)? Can you provide a "screenshot"? > (This is not the case for the browser at the opensolaris site.) I am getting > the tooltip to appear, but now the display looks pretty bad due the congested > tiny columns. So I guess my question now is there a way, other than modifying > Annotate.getWidestRevision and Annotate.getWidestAuthor to get wider columns > so that the display is readable? Not really, since later versions probably rely on these values (to pad on demand correctly). A better workaround could be modifying the view: http://src.iws.cs.ovgu.de/source/xref/opengrok-jel/web/list.jsp#57 ff. Another workaround might be to use em instead of ex. Actually it shouldn't make any difference, since in a monospaced font an x should have the same width like an m, but browsers may think different ;-) ... > Do you know happen to know what version the opensolaris site actually > running? I am noticing that the generated pages are getting different content > than the ones from .11. For instance, the width determination in .11 looks > like the following: > > <style type="text/css">.blame .r { width: 6ex; } .blame .a { width: 6ex; } > </style> This indicates, that Annotate.getWidest{Revision|Author} returns 0, which seems to be bogus, if there are annotations available. But from your previous description I assume, that there are none, right? > but I could not find a similar construct at all in the opensolaris site usage. Yes, this version uses just a "hardcoded" css value: http://src.opensolaris.org/source/xref/opengrok/trunk/web/default/style.css#449 But according to http://src.opensolaris.org/source/xref/opengrok/trunk/CHANGES.txt it seems to be v0.10 ... Have fun, jel. PS: I almost finished another proof-of-concept version, which completely eleminates the need to set an explicit width for these "columns" ... But need to test it tomorrow ... -- Otto-von-Guericke University http://www.cs.uni-magdeburg.de/ Department of Computer Science Geb. 29 R 027, Universitaetsplatz 2 39106 Magdeburg, Germany Tel: +49 391 67 12768 _______________________________________________ opengrok-dev mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/opengrok-dev
