On Fri, Jun 08, 2012 at 01:11:58PM +0000, [email protected] wrote:
> http://defect.opensolaris.org/bz/show_bug.cgi?id=19215
>
> --- Comment #11 from Lubos Kosco <[email protected]> 2012-06-08 13:11:53
> UTC ---
> (In reply to comment #10)
> > +1 for the idea to share IndexReaders.
> >
> > However, AFAICS, the implementation is buggy and has IMHO other problems.
>
> which ones in particular?
>From a quick look only, the obvious things:
- SearcherCache has "no shutdown" method: that smells a little bit ...
- introduces unneeded dependencies into SearchHelper/WebAppListener etc.
e.g. SearchHelper itself should not depend on any servlet context
- doesn't really separate concerns: i.e. merges a lot of stuff into
SearchHelper, which should be actually in the SearcherCache itself
- seems to duplicate stuff, which lucene is already doing
- to fix the leaks, isn't something like this sufficient?:
foreach (IndexReader r: searcherr.getSubReaders()) {
r.close();
}
searcher.close()
Anyway, to get a better picture, I probably need to look into lucene as
well/first ...
Cheers,
jel.
--
Otto-von-Guericke University http://www.cs.uni-magdeburg.de/
Department of Computer Science Geb. 29 R 027, Universitaetsplatz 2
39106 Magdeburg, Germany Tel: +49 391 67 12768
_______________________________________________
opengrok-dev mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/opengrok-dev
