http://defect.opensolaris.org/bz/show_bug.cgi?id=19217

--- Comment #6 from Lubos Kosco <[email protected]> 2012-06-20 16:23:23 
UTC ---
(In reply to comment #4)
> > - you made a lot of customizations and improvements (either for token 
> > parser or
> > for xref parser) and I am wondering if some of them couldn't be generalized 
> > for
> > all languages - naturally I'd be happy if you could generalize them and get
> > them up to all *.lex files if appropriate
> 
> The part that I though that it could be generalized -- the state stack,
> yypush() and yypop() -- was indeed generalized.

yes, I noticed those, thank you
as Knut pointed out he is using something similar in ShAnalyzer, might be
worthwhile checking and comparing which version needs improvement (or make a
hybrid of best of both)

> 
> I don't know which other languages have some sort of nested structure (in this
> context where we basically need mainly to distinguish only comments, strings
> and the rest) that could benefit from this. PHP benefits from this because of

I think some of other analyzers - perl/python or java do the distinguish of
comments,strings,etc. in an easy way using jflex (so you might compare them
also to see which way is better and which one can be improved ... )

> string interpolation and script/non-script blocks.

thanks for looking into this (feel free to put it into new bug, after all we
will be eventually improving ALL analyzers to be better/faster)

btw. feel free to look at how to run junit (ant is preferred, maven testing
doesn't work 100% for me :( )for whole project in README, ev. there are
findbugs/checkstyle targets

L

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
opengrok-dev mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/opengrok-dev

Reply via email to