http://defect.opensolaris.org/bz/show_bug.cgi?id=19225
Summary: AccuRev may have bad impact on repo scan
Classification: Development
Product: opengrok
Version: unspecified
Platform: ANY/Generic
OS/Version: All
Status: NEW
Severity: normal
Priority: P3
Component: analyzer
AssignedTo: [email protected]
ReportedBy: [email protected]
CC: [email protected]
The AccuRev support seems to have several problems:
Biggest one IMHO is the AccuRevRepository:isRepositoryFor(...), which forks an
accurev process for each file to be tested. For auto repo detection (which is
probably used by most users) this may have a really bad impact (no matter,
whether there is actually a accrev repo or not), since the scanner walks down
the source root tree ... So if AccuRev is installed, but one doesn't have
AccuRev, for now it is probably the best to set the JVM property
org.opensolaris.opengrok.history.AccuRev to an invalid path so that isWorking()
always returns false and doesn't try it again and again (add README note?) ...
Also several times there are exceptions declared, which are actually not thrown
(e.g. AccuRevRepository:annotate) -> sounds supicious ...
Last but not least: AccuRevHistoryParser:processStream doesn't do, what's
documented above its while loop. Probably an import/auto-format problem ...
--
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
opengrok-dev mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/opengrok-dev
