On Thu, May 19, 2011 at 07:28:10AM +0200, Trond Norbye wrote: > > On 19. mai 2011, at 03.02, Jens Elkner wrote: > > > On Wed, May 18, 2011 at 09:44:43PM +0000, knut.hat...@oracle.com wrote: > >> Author: Knut Anders Hatlen <knut.hat...@oracle.com> > >> Repository: /hg/opengrok/trunk > >> Latest revision: 31c824bb839936593a6b0cfe12f6aaefc056e726 > >> Total changesets: 1 > >> Log message: > >> Move ensureCommand() from RepositoryInfo down to Repository > >> > >> Files: > >> update: src/org/opensolaris/opengrok/history/Repository.java > >> update: src/org/opensolaris/opengrok/history/RepositoryInfo.java > > > > Yeah - actually RepositoryInfo doesn't make sense at all. I.e. IMHO > > everything from there should be moved down to Repository and RepoInfo > > removed: The only place I see, where it is [mis-]used to pass a > > "possibly a repo" directory, is HistoryGuru#addRepo*. Also isWorking() > > is usually tightly coupled to ensureCommand() ... > > RepositoryInfo is used by the JMX layer to transfer the information about > the repository from the server to a "client" over JMX (so that a configuration > "application" could initiate objects from it)
So replace it with 'Repository' and you are done ;-) Cheers, jel. -- Otto-von-Guericke University http://www.cs.uni-magdeburg.de/ Department of Computer Science Geb. 29 R 027, Universitaetsplatz 2 39106 Magdeburg, Germany Tel: +49 391 67 12768 _______________________________________________ opengrok-discuss mailing list opengrok-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/opengrok-discuss
