Hello! Quoting r. Roland Dreier ([EMAIL PROTECTED]) "Re: [openib-general] MT25218 (aka Arbel memfree) support": > Michael> What would be the best way to organise this code? I > Michael> guess could be two thinkable ways to do this: > > Michael> 1. Add the functionality to the mthca module, use a > Michael> run-time flag to describe hardware differences. Thus, > Michael> the same module will handle devices of all types. > > I've already started adding some memfree support ot the mthca module > (following this approach). So far the code does initialization > through MAP_FA and RUN_FW, and calls QUERY_DEV_LIM.
Yep, I see that. I think its a valid approach - although I thought that it is better to put the memfree code in a separate file. I guess we can always optimise to compile-time checks it later. > By the way, there's no need for a runtime flag, the PCI device ID is > sufficient to distinguish Tavor mode from Arbel mode. > > - Roland How do you mean? I see you use the hca_type flag? MST _______________________________________________ openib-general mailing list [EMAIL PROTECTED] http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
