At 05:09 PM 6/23/2005, Grant Grundler wrote: >On Thu, Jun 23, 2005 at 04:55:38PM -0400, James Lentini wrote: >> My argument in favor of retaining them is that dapl_evd_wc_to_event() >> will crash if the cookie NULL. A BUG_ON will detect this situation ... >The tombstone from the data page fault panic should make this nearly >as obvious as the BUG_ON(). Yes, I agree a BUG_ON() is completely >obvious. But it's also burning CPU cycles for something that
Not to argue one way or the other, but if this cookie is NULL, whose fault would that be? I think that should govern whether it's common enough to warrant BUG_ON or rare enough to warrant a straight crash. I would suggest BUG_ON only if it were possible to trigger this from a loadable module, etc. Tom. _______________________________________________ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general