On Tue, Jun 28, 2005 at 07:10:13AM -0700, Roland Dreier wrote:
>     Gleb> Yes, but don't forget the first part of my patch (for
>     Gleb> libibverbs/src/device.c) I think it should be applied to.
> 
> Yes, I guess it makes sense.
> 
> > -   mm = get_task_mm(current);
> 
>     Gleb> Are you sure that ib_umem_account will run on behalf the
>     Gleb> process that schedules it?  Anyway you are correctly using
>     Gleb> work->mm in the rest of the function so this line should be
>     Gleb> dropped I think.
> 
> The '-' at the beginning of the line means it is being deleted in the
> patch!  Of course schedule_work() delegates the work to a different
> process so the get_task_mm() must be done in the original process.
> 
Oops. I should be more careful :)

--
                        Gleb.
_______________________________________________
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

Reply via email to