On Mon, Jul 11, 2005 at 09:47:04AM -0700, Caitlin Bestler wrote: > The attached .h files follow the alternate approach where each > transport can define its own specifics in a supplemental .h file > and avoid the massive union approach. > > This is mostly cosmetic, except for the work request. Because > some work request opcodes are transport specific the work request > itself has to follow the same approach of deferred sub-typing > rather than unioning. > > The impact of this on the existing code would be quite wide, > but quite shallow. Many types would be renamed form 'ib_xyz' > to 'rdma_xyz', if being used in transport neutral code. Or > when staying infiniband specific fields that now qualified > as transport neutral would require "common." to be inserted > before the field name. Some constants are shifted from IB_XXX > to RDMA_XXX. > > The goal of these changes is to allow users of the core > services to code *most* of their logic without having to > reference transport specific fields.
This looks very nice to me, one nitpick: I think ibonly_verbs.h should be called just ib_verbs.h _______________________________________________ openib-general mailing list [email protected] http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
