On Sun, 2005-08-14 at 09:11, Eitan Zahavi wrote: > Hi Hal, > > > A couple of things: > > > > The patch appears to be whitespace wrapped. > > patching file include/configure.in > > patch: **** malformed patch at line 11: depend on? > [EZ] I used Thunderbird which to my best knowledge does not corrupt > the white space.
Just look at the line in question in the email (and the patch). It was made into 2 lines likely by your mailer. > > Also for debug, should -O0 be removed as Michael suggests ? > [EZ] I will provide a mode where if the user provide a CLAFS on the > command line that includes other optimization mode it will be used. > The problem with MST proposal is that if one does not provide CFLAGS > the default would have been -O2 . > > So I'm looking for a way to use a default of -O0 on debug builds. > > Should I provide the patch in pieces or wait until all these features > are in? It's up to you. IMO it can wait. > > Also, why are files without changes included in the patch ? > [EZ] I will double check. -- Hal _______________________________________________ openib-general mailing list [email protected] http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
