On Aug 16, 2005, at 10:12 AM, Michael S. Tsirkin wrote:
Its a mystery then. IMO, even if we agree on using list_del_init (as discussed below) we should add a BUG_ON(!conn->src_port) as a sanity check.
Yeah, let's do that.
Doesnt INIT_LIST_HEAD do this? list_del_init seems to be an exact match for our case: its a function that is safe to call twice on the same entry, and it lets you check that entry is on some list by !list_empty. Example: kernel/posix-timers.c
Sounds good. Are you going to code up a patch? -tduffy _______________________________________________ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general