Hi Michael, On Mon, 2005-08-29 at 03:23, Michael S. Tsirkin wrote: > Quoting Hal Rosenstock <[EMAIL PROTECTED]>: > > Index: mad_rmpp.c > > =================================================================== > > --- mad_rmpp.c (revision 3197) > > +++ mad_rmpp.c (working copy) > > @@ -593,7 +593,8 @@ > > Hal, could you diff with -p in the future please? > This makes the function name visible in the patch, making it > possible to understand what is being changed without applying it.
I'll try harder to remember to do this. > > rmpp_mad->rmpp_hdr.paylen_newwin = > > cpu_to_be32(mad_send_wr->total_seg * > > (sizeof(struct ib_rmpp_mad) - > > - offsetof(struct ib_rmpp_mad, data))); > > + offsetof(struct ib_rmpp_mad, data)) - > > + mad_send_wr->pad); > > BTW, I just noticed that whitespace was (and remains) broken in these lines: > indentation is done by spaces. The whitespace is preceeded by tabs and is to make the parameters line up. I thought that was allowable coding style. It has been used in many places in OpenIB code. -- Hal _______________________________________________ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
