Hal Rosenstock wrote:
Looks good. One comment below on agent_send_response.

Have you tested this ?

I did run with this change (along with the related changes to mthca and sa_query). I was able to bring up the node, run ipoib, cmtest, and cmatose.

+void agent_send_response(struct ib_mad *mad, struct ib_grh *grh,

   ^^^^
   int

Shouldn't this be left as int (and set error returns internal to this
routine where they occur) ? There seem to be a number of them although
the number has been reduced.

From what I could see, this was only called from mad.c, which no longer uses the return value.

- Sean
_______________________________________________
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

Reply via email to