Hi Yael, On Wed, 2005-12-07 at 06:59, Yael Kalka wrote: > Hi Hal, > If you look at the code - currently the What is returned is a record > with the > local SMInfo record. > The code should be fixed to return a table, or a requested SMInfo record > - > not only of the local port. > So currently - a table is not returned, and the code isn't correct with > or > without the patch... > This issue should be added to our to-do list.
Are you saying that because of that the GetTable should not be accepted until this is fixed or is it a separate issue ? There is more to do here as you point out and I will track this on the TODO list. Do you have other things for this list (see management/osm/doc/todo) ? -- Hal > Yael > > -----Original Message----- > From: Hal Rosenstock [mailto:[EMAIL PROTECTED] > Sent: Tuesday, December 06, 2005 4:06 PM > To: Yael Kalka > Cc: [email protected] > Subject: [PATCH] OpenSM: SA SMInfoRecord should support GetTable as well > as Get method > > > OpenSM: SA SMInfoRecord should support GetTable as well as Get method > > Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> > > Index: osm_sa_sminfo_record.c > =================================================================== > --- osm_sa_sminfo_record.c (revision 4323) > +++ osm_sa_sminfo_record.c (working copy) > @@ -165,7 +165,8 @@ osm_smir_rcv_process( > > CL_ASSERT( p_sa_mad->attr_id == IB_MAD_ATTR_SMINFO_RECORD ); > > - if (p_sa_mad->method != IB_MAD_METHOD_GET) > + if ( (p_sa_mad->method != IB_MAD_METHOD_GET) && > + (p_sa_mad->method != IB_MAD_METHOD_GETTABLE) ) > { > osm_log( p_rcv->p_log, OSM_LOG_ERROR, > "osm_smir_rcv_process: ERR 2804: " _______________________________________________ openib-general mailing list [email protected] http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
