On Thu, 2006-02-09 at 17:25 -0800, Hefty, Sean wrote:
> Here's an updated version of rping. I restructured to code to make it
> more modular, reduce the size of some of the functions, simplify some
> areas, and make it more consistent. The updated version worked for my
> limited testing. Please review the changes to see if I changed any of
> the intended functionality.
I like what you did on making it more modular! I don't see any real
functional changes, but you removed the simple private data exchange.
Any particular reason?
Also:
<snip>
> +static int rping_create_qp(struct rping_cb *cb)
> +{
> + struct ibv_qp_init_attr init_attr;
> + // struct ibv_qp_attr qp_attr;
> + int ret;
> +
> + memset(&init_attr, 0, sizeof(init_attr));
> + init_attr.cap.max_send_wr = RPING_SQ_DEPTH;
> + init_attr.cap.max_recv_wr = 2;
> + init_attr.cap.max_recv_sge = 1;
> + init_attr.cap.max_send_sge = 1;
> + init_attr.qp_type = IBV_QPT_RC;
> + init_attr.send_cq = cb->cq;
> + init_attr.recv_cq = cb->cq;
> +
> + if (cb->server) {
> + ret = rdma_create_qp(cb->child_cm_id, cb->pd,
> &init_attr);
> + if (!ret)
> + cb->qp = cb->child_cm_id->qp;
> + } else {
> + ret = rdma_create_qp(cb->cm_id, cb->pd, &init_attr);
> + if (!ret)
> + cb->qp = cb->cm_id->qp;
> + }
> +
> +// if (ret) {
> +// cb->qp = NULL;
> +// return ret;
> +// }
> +//
> +// qp_attr.qp_access_flags = IBV_ACCESS_REMOTE_READ|
> +// IBV_ACCESS_REMOTE_WRITE;
> +// ret = ibv_modify_qp(cb->qp, &qp_attr, IBV_QP_ACCESS_FLAGS);
> +// if (ret)
> +// printf("ibv_modify_qp returned %d\n", ret);
> + return ret;
> +}
I added this qp_modify code during testing because the server's initial
rdma read request wasn't being processed. I later found out that this
was due to the server path not reaping the "CONNECTED" event prior to
posting the rdma read wr. Now I notice you commented out this code (but
left it in).
So what's up with these access flags on qp? You cannot set them on qp
creation...only on qp modify. That seems strange. Since rdma
read/writes work without these attributes set, I'm wondering what they
really do?
Steve.
_______________________________________________
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general
To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
