Michael S. Tsirkin wrote: > We already do state tracking to join/leave groups properly. > It would be easier to review this change if you left killing off > mcast->done and other such improvements for a separate patch.
The multicast module does reference counting and completion handling for us. Migrating ipoib to use ib_multicast, but keeping unnecessary duplicated functionality around in ipoib doesn't make sense. Also, the callback can be invoked multiple times, so a 'done' flag isn't useful to track if the callback has been invoked. - Sean _______________________________________________ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general