Quoting r. Roland Dreier <[EMAIL PROTECTED]>: > Subject: Re: [PATCH] IB/mthca: fix MAD extended header format > > > Roland, the offsets look wrong. Am I missing something? > > Please review vs the spec, and if correct consider for 2.6.19. > > I just applied your original patch without checking it carefully :) > Yes, the offsets in your patch look like they match the PRM now. > However: > > > +#define MAD_IFC_RLID_OFFSET 0x10e > > I don't see anything about RLID in either the latest Tavor or Arbel > specs -- they say the RLID goes in the input modifier (as the current > mthca code also does). So is putting the RLID into the mailbox > needed? Or should we follow the docs?
Old PRM versions (1.01) used to have rlid there - that's why it was in original coed and I just kept it. It kind of looked safest to keep it around, just in case there's some old firmware that wants it there. Most likely we can drop this - worst case user will need to upgrade the firware. You decide. -- MST _______________________________________________ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general