Quoting r. Michael S. Tsirkin <[EMAIL PROTECTED]>: > Subject: [PATCH repost] IB/srp: destroy/recreate qp/cq at reconnect > > From: Ishai Rabinovitz <[EMAIL PROTECTED]> > > This makes SRP more robust in presence of hardware errors > and is closer to behaviour suggested by IB spec, > reducing chance of stale packets. > > Signed-off-by: Ishai Rabinovitz <[EMAIL PROTECTED]> > Signed-off-by: Michael S. Tsirkin <[EMAIL PROTECTED]> > > --- > > Hello, Roland! > What do you think about this? Please consider for 2.6.19. > > For some reason (could be a firmware problem) I got a CQ overrun in SRP. > Because of that there was a QP FATAL. Since in srp_reconnect_target we are not > destroying the QP, the QP FATAL persists after the reconnect. > In order to be able to recover from such situation I suggest we > destroy the CQ and the QP in every reconnect. > > This also corrects a minor spec in-compliance - when srp_reconnect_target > is called, srp destroys the CM ID and resets the QP, the new connection > will be retried with the same QPN which could theoretically lead to > stale packets (for strict spec compliance I think QPN should not be reused > till all stale packets are flushed out of the network).
Roland, what do you think about this patch? Seems like a good idea, to me. -- MST _______________________________________________ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
