Seems fine, with the minor comment:

 > +#ifdef CONFIG_HT_IRQ
 >      case PCI_DEVICE_ID_INFINIPATH_HT:
 >              ipath_init_iba6110_funcs(dd);
 >              break;
 > +#endif
 > +#ifdef CONFIG_PCI_MSI
 >      case PCI_DEVICE_ID_INFINIPATH_PE800:
 >              ipath_init_iba6120_funcs(dd);
 >              break;
 > +#endif

would it make sense to add the ifdef to the struct pci_driver too, so
that the probe function doesn't even get called for a device the
driver can't handle?

 - R.

_______________________________________________
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

Reply via email to