Hello Predrag,
Thanks for the feedback, I'll look into it with 5.0rc1 - I only tested across a few latest 4.3.* releases during the patch's evolution. OTOH, you used an older version (published in March) which may fail on recent OI Hipster which changed the PKG FMRI numbering scheme - this is what my more recent fixes amend. As for "patch unexpectedly ends in middle of line" - I didn't see that one yet, did you download it from Github (as "raw" text https://raw.githubusercontent.com/jimklimov/vboxconfig_sh/master/vboxconfig.sh.patch), or from that e-mail post? Perhaps the mailing-list archival and/or download process was faulty? Finally, regarding matching of the filename - in the recent version of the patch, it now references "subdirname/vboxconfig.sh" in both original and new versions so as to not confuse the patch programs. I also added the copy-pasteable package-patching procedure to README in the GitHub project to facilitate installations. Thanks, Jim ----- Исходное сообщение ----- От: "Predrag Zecevic [Unix Systems Administrator]" <[email protected]> Дата: Wednesday, June 24, 2015 14:52 Тема: Re: [OpenIndiana-discuss] [OmniOS-discuss] Fix to VirtualBox installer under OI/OmniOS Кому (To): [email protected] > Hi Jim, > > I was curious, so tried to test on *installed* tree (5.0.0_RC1): > > $ pfexec bash > $ cd /opt/VirtualBox > $ ls -la vboxconfig.sh > -rwxr-xr-x 1 0 2 45K Jun 1 20:15 vboxconfig.sh* > > $ gpatch -p1 < vboxconfig.sh.patch > can't find file to patch at input line 10 > Perhaps you used the wrong -p or --strip option? > The text leading up to this was: > -------------------------- > |This patch adds the ability for VirtualBox packaged installer script > |to configure USB filters on OpenSolaris and non-Oracle descendant > |distributions. For those distros not immediately covered by the > patch,|there is an ability to force the logic by 'touch > /etc/vboxinst_vboxusb'| > |Copyright (C) 2013-2015 by Jim Klimov under the terms of MIT License. > | > |--- vboxconfig.sh.orig 2015-03-02 16:17:43.000000000 +0100 > |+++ vboxconfig.sh 2015-03-09 > 15:30:35.673996000 +0100 > -------------------------- > File to patch: > vboxconfig.sh <---- asked me > here to enter file to patch > patching file vboxconfig.sh > Hunk #1 succeeded at 1 with fuzz 2. > Hunk #2 succeeded at 286 (offset 6 lines). > Hunk #3 succeeded at 315 (offset 6 lines). > Hunk #4 succeeded at 352 (offset 6 lines). > Hunk #5 succeeded at 703 (offset 6 lines). > Hunk #6 succeeded at 751 (offset 6 lines). > patch unexpectedly ends in middle of line > patch unexpectedly ends in middle of line > $ ls -al vboxc* > -rwxr-xr-x 1 root bin 47K Jun 24 14:40 vboxconfig.sh > -rwxr-xr-x 1 root bin 45K Jun 1 20:15 > vboxconfig.sh.orig-rw-r--r-- 1 root root 8.6K Jun 24 14:40 > vboxconfig.sh.patch$ > > I am not sure if that is supposed to be so, just FYI. > > Thank you and very best regards. > > On 06/24/15 02:04 PM, Jim Klimov wrote: > > > > Hello all, > > > > Earlier in March I posted a patch that fixes installation of > VirtualBox on non-Oracle Solaris hosts (e.g. OpenIndiana and > OmniOS). Lest it be lost in the list archives, I moved the patch > (now licensed as GPLv2 to match VirtualBox licensing) and an > accompanying README to GitHub: > https://github.com/jimklimov/vboxconfig_sh> > > Feel free to add the changes into the distributions (if you > maintain packages/repositories), so such hackery won't be needed ;) > > > > Thanks, > > Jim Klimov > > > > > > > > > > ----- �������� ��������� ----- > > ��: Jim Klimov <[email protected]> > > ����: Monday, March 16, 2015 9:30 > > ����: [OmniOS-discuss] Fix to VirtualBox installer under OI/OmniOS > > ���� (To): [email protected], omnios-discuss > <[email protected]> > > ����� (Cc): [email protected] > > > > > >> Hello all, > > > >> Earlier this month I posted to the VirtualBox lists my patch > for vboxconfig.sh to better support > >> installation on non-Sun/Oracle Solaris-like hosts, tested on > OI (Hipster) and OmniOS (bloody). > >> It may support SXCE as well (has the code, but was not > practically tested lately) since there are > >> aspects where SXCE was like Solaris 10 (SVR4 packaging) and > yet more advanced than that > >> (CrossBow, etc.). > > > >> Unfortunately, so far the post fell through the cracks... so > for possible integration into packages > >> provided by the illumos distributions (e.g. to help the work > done by Thomas Gouverneur to turn > >> SVR releases into IPS, or to support proper GPL-source builds > of VirtualBox), I'd like to repost > >> these fixes here too. Feel free to build on them, to make VB > updates hiccup-less ;) > > > >> In my practice, it sufficed to "pkgtrans" the Oracle VB > package into a directory, patch the script > >> "vboxconfig.sh" provided in the installation image, update > the "pkgmap" with new values for > >> size and checksum of the changed file, (run "pkgrm" to remove > an obsoleted installation) and > >> "pkgadd" to install the package from the directory. > >> > > > > > >> --- > > > >> The reposted part: > > > >> http://article.gmane.org/gmane.comp.emulators.virtualbox.devel/7390 > >> Date: 2015-03-09 15:09:25 GMT > > > >> Hello all, > > > >> I submit a patch which should simplify installation of modern > VirtualBox on some > >> non-Oracle derivate distributions of Solaris which are known > to host VirtualBox > >> just fine. Most of the patch deals with "proper" detection of > major and minor OS > >> version numbers on those distributions. Also there is now a > touchable filename > >> to enforce installation of USB filters and corresponding UNIX > group accounts, > >> as a workaround for further distros not detected as supported > by even new code. > > > >> I submit this patch under the terms of MIT license. > > > >> This was last tested with VirtualBox 4.3.24 and OpenIndiana > Hipster and OmniOS > >> Bloody, all updated today to the most current states available. > > > >> Note this was not yet tested in practice with SXCE although > snippets were developed > >> that should work there. I don't expect there are many of > those installations left beside my > >> closet, but those are all pleased with old VBox versions for > now... ain't broke, you know ;) > > > > > >> Hope this helps, > >> // Jim Klimov > > > >> > > > > > _______________________________________________ > > > OmniOS-discuss mailing list > > > [email protected] > > > http://lists.omniti.com/mailman/listinfo/omnios- > discuss> > > -- > > > > > +============================================================+> | > | > > | ������ > �������, Jim Klimov | > > | ����������� > �������� CTO | > > | ��� "ƾ� � > ��" JSC COS&HT | > > > | | > > | +7-903-7705859 > (cellular) mailto:[email protected] | > > > | CC:[email protected],[email protected] | > > > +============================================================+> | () > ascii ribbon campaign - against html mail | > > | > /\ - against microsoft attachments | > > > +============================================================+> > _______________________________________________> openindiana- > discuss mailing list > > [email protected] > > http://openindiana.org/mailman/listinfo/openindiana-discuss > > > > -- > Predrag Zečević > Technical Support Analyst > 2e Systems GmbH > > Telephone: +49 6196 9505 815, Facsimile: +49 6196 9505 894 > Mobile: +49 174 3109 > 288, Skype: predrag.zecevic > E-mail: [email protected] > > Headquarter: 2e Systems GmbH, Königsteiner Str. 87, > 65812 Bad Soden am Taunus, Germany > Company registration: Amtsgericht Königstein (Germany), HRB 7303 > Managing director: Phil Douglas > > http://www.2e-systems.com/ - Making your business fly! > > _______________________________________________ > openindiana-discuss mailing list > [email protected] > http://openindiana.org/mailman/listinfo/openindiana-discuss -- +============================================================+ | | | Климов Евгений, Jim Klimov | | технический директор CTO | | ЗАО "ЦОС и ВТ" JSC COS&HT | | | | +7-903-7705859 (cellular) mailto:[email protected] | | CC:[email protected],[email protected] | +============================================================+ | () ascii ribbon campaign - against html mail | | /\ - against microsoft attachments | +============================================================+ _______________________________________________ openindiana-discuss mailing list [email protected] http://openindiana.org/mailman/listinfo/openindiana-discuss
