Segher Boessenkool wrote: >>> info->io_regsize = regsize ? *regsize : DEFAULT_REGSIZE; >>> >>> [Please note that fixes a copy/paste bug, too]. >> >> There is no DEFAULT_REGSIZE, all the code is using DEFAULT_REGSPACING >> as the default size. >> It looks like the code assumes that the registers are located next to >> each other. > > It would be more logical to only use REGSIZE then, heh. > >> If thats not good, DEFAULT_REGSIZE should be introduced and used in >> all other probe functions as well. >> That would be a seperate issue . > > You could start the cleanup by doing > > #define DEFAULT_REGSIZE DEFAULT_REGSPACING > > and using REGSIZE in the new code. Or replace s/REGSPACING/REGSIZE/ > throughout. Or something. > > Not your fault though, just leave it as-is if you don't feel > like fixing others' mess :-) Doing this is fine with me, it needs to be done.
-Corey ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Openipmi-developer mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openipmi-developer
