I am just coming up for air from a critical issue. I spent today updating the patches to 2.6.24, testing, and getting ready to send the patches. So probably tomorrow.
-corey Carol Hebert wrote: > Hi Corey, > > I was just hoping to get an update on when you think you'll be sending > this dmi_scan.c patch upstream? > > Thank you very much, > > Carol > > > ------------------------------------------------------------------------ > > Subject: > [PATCH] Change ipmi device node ordering for multi-BMC systems back to > probe order > From: > Carol Hebert <[EMAIL PROTECTED]> > Date: > Thu, 31 Jan 2008 15:32:43 -0800 > To: > Corey Minyard <[EMAIL PROTECTED]> > > To: > Corey Minyard <[EMAIL PROTECTED]> > CC: > [email protected] > > > On Fri, 2008-01-18 at 22:47 -0600, Corey Minyard wrote: > >> If we take this patch, can you send this in standard patch format with a >> patch header and signed-off-by line? I'll need that to send it on. >> >> However, I think there is another way to handle this. udev should be >> able to order these however you like. You should be able to use the >> device ID from /sys/class/ipmi/ipmi<n>/dev to tell udev what to do. >> Generally, device order is arbitrary and to force it you should use udev >> rules. >> >> But we should probably do both. >> >> Thanks, >> >> -corey >> >> > > Hi Corey, > > Sorry for the delay. Here is the patch. Please let me know if you have > any issues or concerns with it. > > --------------------------------------------------------- > > > Subject: Change ipmi device node ordering to reflect probe order > > Currently, on systems with multiple BMC interfaces, the ipmi device > names are being created in reverse order relative to how they are > discovered on the system (e.g. on an IBM x3950 multinode server with N > nodes, the device name for the BMC in the first node is /dev/ipmiN-1 and > the device name for the BMC in the last node is /dev/ipmi0, etc.). The > problem is caused by the list handling routines chosen in dmi_scan.c. > Using list_add() causes the multiple ipmi devices to be added to the > device list using a stack-paradigm and so the ipmi driver subsequently > pulls them off during initialization in LIFO order. This patch changes > the dmi_save_ipmi_device() list handling paradigm to a queue, thereby > allowing the ipmi driver to build the ipmi device names in the order in > which they are found on the system. > > Signed-off-by: Carol Hebert <[EMAIL PROTECTED]> > > > ------------------------------------------------------------------------ > > --- linux-2.6.24.orig/drivers/firmware/dmi_scan.c 2008-01-30 > 11:21:55.000000000 -0800 > +++ linux-2.6.24/drivers/firmware/dmi_scan.c 2008-01-30 11:18:05.000000000 > -0800 > @@ -219,7 +219,7 @@ static void __init dmi_save_ipmi_device( > dev->name = "IPMI controller"; > dev->device_data = data; > > - list_add(&dev->list, &dmi_devices); > + list_add_tail(&dev->list, &dmi_devices); > } > > /* > > ------------------------------------------------------------------------ > > ------------------------------------------------------------------------- > This SF.net email is sponsored by: Microsoft > Defy all challenges. Microsoft(R) Visual Studio 2008. > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ > ------------------------------------------------------------------------ > > _______________________________________________ > Openipmi-developer mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/openipmi-developer > ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Openipmi-developer mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openipmi-developer
