Andrew Morton wrote:
> On Wed, 13 Feb 2008 10:23:42 -0600
> Corey Minyard <[EMAIL PROTECTED]> wrote:
>
>
>> From: Corey Minyard <[EMAIL PROTECTED]>
>>
>> The "run_to_completion" mode was somewhat broken. Locks need to be
>> avoided in run_to_completion mode, and it shouldn't be used by normal
>> users, just internally for panic situations.
>>
>> This patch removes locks in run_to_completion mode and removes the
>> user call for setting the mode. The only user was the poweroff
>> code, but it was easily converted to use the polling interface.
>>
>> + /*
>> + * Spin until our message is done.
>> + */
>> + while (atomic_read(&dummy_count) > 0) {
>> + ipmi_poll_interface(user);
>> + barrier();
>> + }
>>
>
> we'd normally use cpu_relax() here.
>
Yes, that's what I should have used. I'll submit a new patch to fix this.
-corey
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Openipmi-developer mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openipmi-developer
