The wrong return value is being tested when allocating a platform device in the IPMI SI code. Check the right value.
Signed-off-by: Corey Minyard <[email protected]> --- Index: linux-2.6.25/drivers/char/ipmi/ipmi_si_intf.c =================================================================== --- linux-2.6.25.orig/drivers/char/ipmi/ipmi_si_intf.c +++ linux-2.6.25/drivers/char/ipmi/ipmi_si_intf.c @@ -2864,7 +2864,7 @@ static int try_smi_init(struct smi_info */ new_smi->pdev = platform_device_alloc("ipmi_si", new_smi->intf_num); - if (rv) { + if (!new_smi->pdev) { printk(KERN_ERR "ipmi_si_intf:" " Unable to allocate platform device\n"); ------------------------------------------------------------------------------ Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H _______________________________________________ Openipmi-developer mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openipmi-developer
