On Sun, Feb 23, 2014 at 08:23:35PM -0600, [email protected] wrote:
> @@ -1194,7 +1223,17 @@ int ipmi_set_gets_events(ipmi_user_t user, int val)
>       INIT_LIST_HEAD(&msgs);
>  
>       spin_lock_irqsave(&intf->events_lock, flags);
> -     user->gets_events = val;
> +     if (user->gets_events == !!val)
> +             goto out;
> +
> +     user->gets_events = !!val;

Why not have val declared as bool and let compiler convert as needed?

Thanks.

-- 
Dmitry

------------------------------------------------------------------------------
Flow-based real-time traffic analytics software. Cisco certified tool.
Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer
Customize your own dashboards, set traffic alerts and generate reports.
Network behavioral analysis & security monitoring. All-in-one tool.
http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.clktrk
_______________________________________________
Openipmi-developer mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openipmi-developer

Reply via email to