On 12/23/2014 01:03 PM, nick wrote:
> Corey,
> This is what I have so far:
> list_for_each_entry(priv,&priv->recv_msgs, recv_msgs){
> ipmi_free_recv_msg(&priv->recv_msgs);
> }
> However when I build it complains about using a list_head and not a message
> for the function in the loop.
> I searched around and there seems to be no good way to above this as the
> structures don't connect together
> in order to avoid these.
Look around, you will find some examples. Your first parameter there
should be a receive message, not priv, and the third parameter should be
the link in the message, not recv_msgs. You should also use
list_for_entry_safe(), which will take yet another parameter, as you
will be freeing the message and thus cannot use it later.
-corey
> Regards Nick
>
>
> On 2014-12-23 09:13 AM, Corey Minyard wrote:
>> On 12/21/2014 04:37 PM, nick wrote:
>>> Greetings Again Corney,
>>> Hope you are looking forward to the holidays. I am one question, about the
>>> function in my message.
>>> /* FIXME - free the messages in the list. */, is in this function I am
>>> wondering is this needed?
>>> Further more the only reason I can see for it is if we are to free the
>>> linked list of files or
>>> inodes passed to the function, otherwise it's invalid. Please let me known
>>> if should sent in
>>> a patch to remove it or add a for_each_through linked list call that
>>> deletes each file or inode
>>> in the list passed.
>> The recv_msgs list needs to be cleaned up in this case. Basically, just
>> call ipmi_free_recv_msg()
>> on every message in the list. A patch would be appreciated.
>>
>> Thanks,
>>
>> -corey
>>
> ------------------------------------------------------------------------------
> Dive into the World of Parallel Programming! The Go Parallel Website,
> sponsored by Intel and developed in partnership with Slashdot Media, is your
> hub for all things parallel software development, from weekly thought
> leadership blogs to news, videos, case studies, tutorials and more. Take a
> look and join the conversation now. http://goparallel.sourceforge.net
> _______________________________________________
> Openipmi-developer mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/openipmi-developer
------------------------------------------------------------------------------
Dive into the World of Parallel Programming! The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net
_______________________________________________
Openipmi-developer mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openipmi-developer
