On 04/04/2015 09:37 AM, Thomas D. wrote: > Hi Corey, > > Corey Minyard wrote: >> As, I'm so glad I have IPMI working in qemu and can simulate these things. >> >> Can you try the attached patch? > Patch works for me (tested against 3.19.3). On boot I now see > >> [ 8.087977] ipmi_si: The BMC does not support clearing,the recv irq bit, >> compensating, but the BMC needs to be fixed. >> [ 8.171487] ipmi_si 00:06: Found new BMC (man_id: 0x002a7c, prod_id: >> 0x0813, dev_id: 0x20) >> [ 8.171499] ipmi_si 00:06: IPMI kcs interface initialized > and I don't see any repeating "Could not set the global enables" error > messages anymore.
Great, thanks for the testing. I had just hacked this out quickly to try it out, but thanks for the review, too. I've added a "Tested-by" and "Reviewed-by" for you, if that's ok. I'll get this into 4.0, if possible, and into the 3.19 stable kernel. -corey > Thanks! > > > Regarding the patch itself, two things to improve: > > 1) Blank line 26 ... to keep current style change > >> /* >> * Can we clear the global enables receive irq bit? >> */ >> >> bool cannot_clear_recv_irq_bit; >> /* >> * Did we get an attention that we did not handle? >> */ > into > >> /* >> * Can we clear the global enables receive irq bit? >> */ >> bool cannot_clear_recv_irq_bit; >> >> /* >> * Did we get an attention that we did not handle? >> */ > > 2) Wrong comma in line 127 > >> printk(KERN_WARNING PFX "Error getting response from set" >> " global, enables command, cannot check recv irq bit" >> " handling.\n"); > should be > >> printk(KERN_WARNING PFX "Error getting response from set" >> " global enables command, cannot check recv irq bit" >> " handling.\n"); > if I am not wrong. > Same problem in line 138 > >> printk(KERN_WARNING PFX "Invalid return from get global," >> "enables command, cannot check recv irq bit" >> " handling.\n"); > should be > >> printk(KERN_WARNING PFX "Invalid return from get global" >> "enables command, cannot check recv irq bit" >> " handling.\n"); > I think. > > If I am wrong, > >> printk(KERN_WARNING PFX "Invalid return from get global" >> " enables command, cannot check recv irq bit" >> " handling.\n"); > in line 108 needs a comma after "global". > > > -Thomas > > > ------------------------------------------------------------------------------ > Dive into the World of Parallel Programming The Go Parallel Website, sponsored > by Intel and developed in partnership with Slashdot Media, is your hub for all > things parallel software development, from weekly thought leadership blogs to > news, videos, case studies, tutorials and more. Take a look and join the > conversation now. http://goparallel.sourceforge.net/ > _______________________________________________ > Openipmi-developer mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/openipmi-developer ------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ Openipmi-developer mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openipmi-developer
