Hello, (2015/04/24 22:00), Corey Minyard wrote: > Ah, yes, you are correct. Queued for 4.1. Thanks.
Thank you for the review. By the way, I'm planning some enhancements of IPMI driver in panic context. Currently, we can call panic notifiers before crash_kexec() by specifying crash_kexec_post_notifiers as a boot parameter. By utilizing this feature, we can write SEL records before entering kdump process; we can save some information even if kdump fails. Here, notifier calls shouldn't prevent the kdump process. So, the reliability of panic notifier calls is very important. I noticed that there are possible infinite loops in the panic notifier call of IPMI driver (we assume BMC is unreliable). To evict possible infinite loops, I'm considering introducing some retry timeout or retry count limit to the run_to_completion procedure. Do you have any opinions? -- Hidehiro Kawai Hitachi, Ltd. Research & Development Group ------------------------------------------------------------------------------ One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+ applications Performance metrics, stats and reports that give you Actionable Insights Deep dive visibility with transaction tracing using APM Insight. http://ad.doubleclick.net/ddm/clk/290420510;117567292;y _______________________________________________ Openipmi-developer mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openipmi-developer
