Ok, I've added:

Tested-by: Henrik Korkuc <[email protected]>

if that is ok.

-corey

On 08/19/2015 08:02 AM, Henrik Korkuc wrote:
> The patch works for me. There were no "Could not set the global
> enables" at all in dmesg when executing ipmitool commands.
>
> I tried with 4.1.5 and few days old master of linux-stable
>
> On 15-08-18 22:40, Corey Minyard wrote:
>> Can you try the attached patch?  It should auto-detect and compensate.
>>
>> -corey
>>
>> On 08/18/2015 06:38 AM, Henrik Korkuc wrote:
>>> Initialization:
>>> [    8.981172] ipmi message handler version 39.2
>>> [    8.997813] ipmi device interface
>>> [    9.002179] Copyright (C) 2004 MontaVista Software - IPMI Powerdown
>>> via sys_reboot.
>>> [    9.047200] IPMI System Interface driver.
>>> [    9.051849] ipmi_si: probing via SMBIOS
>>> [    9.056237] ipmi_si: SMBIOS: io 0xca8 regsize 1 spacing 4 irq 10
>>> [    9.063049] ipmi_si: Adding SMBIOS-specified kcs state machine
>>> [    9.076464] ipmi_si: Trying SMBIOS-specified kcs state machine at
>>> i/o address 0xca8, slave address 0x20, irq 10
>>> [    9.226065] ipmi_si ipmi_si.0: Using irq 10
>>> [    9.229405] ipmi_si ipmi_si.0: Could not set the global enables:
>>> 0xcc.
>>> [    9.267096] ipmi_si ipmi_si.0: Found new BMC (man_id: 0x0002a2,
>>> prod_id: 0x0100, dev_id: 0x20)
>>> [    9.279494] IPMI poweroff: ATCA Detect mfg 0x2A2 prod 0x100
>>> [    9.285828] IPMI poweroff: Found a chassis style poweroff function
>>> [    9.292976] ipmi_si ipmi_si.0: IPMI kcs interface initialized
>>>
>>>
>>> Rerun of 0x02 (message gets repeated):
>>> # dmesg |tail -n1; echo "----------"
>>> [145215.602590] start_kcs_transaction - 18 2e 02
>>> ----------
>>> root@cephold01-sjc1:/home/henrik# ipmitool raw 6 0x2e 0x02; sleep 1;
>>> dmesg |tail -n1; echo "----------"
>>> Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0 cmd=0x2e
>>> rsp=0xcc): Invalid data field in request
>>> [145233.596151] ipmi_si ipmi_si.0: Could not set the global enables:
>>> 0xcc.
>>>
>>> si_stats:
>>> interrupts_enabled:    1
>>> short_timeouts:        0
>>> long_timeouts:         3619
>>> idles:                 32164
>>> interrupts:            373721
>>> attentions:            0
>>> flag_fetches:          0
>>> hosed_count:           0
>>> complete_transactions: 33586
>>> events:                0
>>> watchdog_pretimeouts:  0
>>> incoming_messages:     0
>>>
>>>
>>> MC Info:
>>> # ipmitool mc info
>>> Device ID                 : 32
>>> Device Revision           : 1
>>> Firmware Revision         : 2.0a
>>> IPMI Version              : 2.0
>>> Manufacturer ID           : 674
>>> Manufacturer Name         : DELL Inc
>>> Product ID                : 256 (0x0100)
>>> Product Name              : Unknown (0x100)
>>> Device Available          : yes
>>> Provides Device SDRs      : yes
>>> Additional Device Support :
>>>      Sensor Device
>>>      SDR Repository Device
>>>      SEL Device
>>>      FRU Inventory Device
>>>      IPMB Event Receiver
>>>      Bridge
>>>      Chassis Device
>>> Aux Firmware Rev Info     :
>>>      0x00
>>>      0x31
>>>      0x0a
>>>      0x0a
>>>
>>> On 15-08-18 13:53, Corey Minyard wrote:
>>>> Well, the BMC appears to have interrupts enabled and does not support
>>>> setting
>>>> the interrupt enable bit in the global enables.
>>>>
>>>> I guess we should see if the interrupts are actually working.  Can you
>>>> send me
>>>> the kernel output from the ipmi_si driver loading?  The lines
>>>> should all
>>>> have ipmi_si
>>>> in them.  That will tell me where it got the interrupt information.
>>>>
>>>> Then send me the output of /proc/ipmi/0/si_stats after running a few
>>>> commands.
>>>> That should tell me if interrupts are actually working.
>>>>
>>>> Next, can you rerun "ipmitool raw 6 0x2e 0x02" again?  In your listing
>>>> below you
>>>> have the last byte as 0x01 twice and didn't run it with 0x02.
>>>>
>>>> And lastly, can you run "ipmitool mc info" and send me the output? 
>>>> If I
>>>> need to
>>>> do this as a blacklist I'll need that output.  I think the
>>>> situation is
>>>> that ACPI or SMBIOS
>>>> is advertising that it has interrupts even though they are not
>>>> supported.  I think I
>>>> can detect this automatically, though.
>>>>
>>>> If interrupts are actually working, I've got a more difficult
>>>> situation
>>>> to handle.
>>>>
>>>> -corey
>>>>
>>>> On 08/18/2015 05:25 AM, Henrik Korkuc wrote:
>>>>> It looks like all of them is a problem... After every command there
>>>>> would be a message in dmesg.
>>>>>
>>>>> # dmesg |tail -n1; echo "----------"
>>>>> [140891.403745] ipmi_si ipmi_si.0: Could not set the global enables:
>>>>> 0xcc.
>>>>> ----------
>>>>> # ipmitool raw 6 0x2f; sleep 1; dmesg |tail -n1; echo "----------"
>>>>>     08
>>>>> [140912.869867] ipmi_si ipmi_si.0: Could not set the global enables:
>>>>> 0xcc.
>>>>> ----------
>>>>> # ipmitool raw 6 0x2e 0x01; sleep 1; dmesg |tail -n1; echo
>>>>> "----------"
>>>>> Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0 cmd=0x2e
>>>>> rsp=0xcc): Invalid data field in request
>>>>> [140913.915045] ipmi_si ipmi_si.0: Could not set the global enables:
>>>>> 0xcc.
>>>>> ----------
>>>>> # ipmitool raw 6 0x2e 0x01; sleep 1; dmesg |tail -n1; echo
>>>>> "----------"
>>>>> Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0 cmd=0x2e
>>>>> rsp=0xcc): Invalid data field in request
>>>>> [140914.970121] ipmi_si ipmi_si.0: Could not set the global enables:
>>>>> 0xcc.
>>>>> ----------
>>>>> # ipmitool raw 6 0x2e 0x04; sleep 1; dmesg |tail -n1; echo
>>>>> "----------"
>>>>>
>>>>> [140916.016644] ipmi_si ipmi_si.0: Could not set the global enables:
>>>>> 0xcc.
>>>>> ----------
>>>>> # ipmitool raw 6 0x2e 0x08; sleep 1; dmesg |tail -n1; echo
>>>>> "----------"
>>>>>
>>>>> [140917.060922] ipmi_si ipmi_si.0: Could not set the global enables:
>>>>> 0xcc.
>>>>> ----------
>>>>>
>>>>> and a run with debug flag:
>>>>> [141144.316148] start_kcs_transaction - 18 01
>>>>> [141144.317982] start_kcs_transaction - 18 2f
>>>>> [141144.318822] start_kcs_transaction - 18 2e 0f
>>>>> [141144.319740] ipmi_si ipmi_si.0: Could not set the global enables:
>>>>> 0xcc.
>>>>> [141144.327156] start_kcs_transaction - 18 33
>>>>> [141144.328069] start_kcs_transaction - b0 00 00
>>>>> [141144.328922] start_kcs_transaction - 18 2f
>>>>> [141145.341225] start_kcs_transaction - 18 01
>>>>> [141145.343324] start_kcs_transaction - 18 2f
>>>>> [141145.344166] start_kcs_transaction - 18 2e 0f
>>>>> [141145.345007] ipmi_si ipmi_si.0: Could not set the global enables:
>>>>> 0xcc.
>>>>> [141145.352412] start_kcs_transaction - 18 33
>>>>> [141145.354375] start_kcs_transaction - b0 00 00
>>>>> [141145.355317] start_kcs_transaction - 18 2e 01
>>>>> [141146.379823] start_kcs_transaction - 18 01
>>>>> [141146.383840] start_kcs_transaction - 18 2f
>>>>> [141146.384801] start_kcs_transaction - 18 2e 0f
>>>>> [141146.385647] ipmi_si ipmi_si.0: Could not set the global enables:
>>>>> 0xcc.
>>>>> [141146.393061] start_kcs_transaction - 18 33
>>>>> [141146.393996] start_kcs_transaction - b0 00 00
>>>>> [141146.394957] start_kcs_transaction - 18 2e 02
>>>>> [141147.410761] start_kcs_transaction - 18 01
>>>>> [141147.412512] start_kcs_transaction - 18 2f
>>>>> [141147.413620] start_kcs_transaction - 18 2e 0f
>>>>> [141147.414469] ipmi_si ipmi_si.0: Could not set the global enables:
>>>>> 0xcc.
>>>>> [141147.421891] start_kcs_transaction - 18 33
>>>>> [141147.422810] start_kcs_transaction - b0 00 00
>>>>> [141147.423777] start_kcs_transaction - 18 2e 04
>>>>> [141148.437792] start_kcs_transaction - 18 01
>>>>> [141148.439615] start_kcs_transaction - 18 2f
>>>>> [141148.440510] start_kcs_transaction - 18 2e 07
>>>>> [141148.441338] ipmi_si ipmi_si.0: Could not set the global enables:
>>>>> 0xcc.
>>>>> [141148.448752] start_kcs_transaction - 18 33
>>>>> [141148.449744] start_kcs_transaction - b0 00 00
>>>>> [141148.450574] start_kcs_transaction - 18 2e 08
>>>>>
>>>>> On 15-08-18 00:31, Corey Minyard wrote:
>>>>>> Joy.  Another broken management controller.
>>>>>>
>>>>>> It appears that the BMC doesn't like setting one of the global
>>>>>> enables
>>>>>> bits.  Yes, this is a different issue.  Can you try the following:
>>>>>>
>>>>>> ipmitool raw 6 0x2f
>>>>>> ipmitool raw 6 0x2e 0x01
>>>>>> ipmitool raw 6 0x2e 0x02
>>>>>> ipmitool raw 6 0x2e 0x04
>>>>>> ipmitool raw 6 0x2e 0x08
>>>>>>
>>>>>> That should tell me which bit is the issue.
>>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> -corey
>>>>>>
>>>>>> On 08/16/2015 02:22 PM, Henrik Korkuc wrote:
>>>>>>> Hey,
>>>>>>>
>>>>>>> Related to
>>>>>>> http://sourceforge.net/p/openipmi/mailman/message/33593756/
>>>>>>>
>>>>>>> Using 4.1.5 kernel built from source, debian Jessie.
>>>>>>> Using "ipmitool lan print" I can reproduce multiple dmesg messages
>>>>>>> "ipmi_si ipmi_si.0: Could not set the global enables: 0xcc."
>>>>>>>
>>>>>>> I even tried compiling kernel with Corey's fix as a head, so it
>>>>>>> does
>>>>>>> not look like regression.
>>>>>>> commit 1e7d6a45f6b10bc48a1453bca3d829e210546571
>>>>>>> Author: Corey Minyard <[email protected]>
>>>>>>> Date:   Fri Apr 3 12:13:48 2015 -0500
>>>>>>>
>>>>>>> Dmesg output with "echo 2 >
>>>>>>> /sys/module/ipmi_si/parameters/kcs_debug"
>>>>>>>
>>>>>>> [  570.903942] start_kcs_transaction - 18 01
>>>>>>> [  570.905744] start_kcs_transaction - 18 2f
>>>>>>> [  570.906579] start_kcs_transaction - 18 2e 0f
>>>>>>> [  570.907456] ipmi_si ipmi_si.0: Could not set the global
>>>>>>> enables: 0xcc.
>>>>>>> [  570.914826] start_kcs_transaction - 18 33
>>>>>>> [  570.915725] start_kcs_transaction - b0 00 00
>>>>>>> [  570.916567] start_kcs_transaction - 18 42 01
>>>>>>> [  570.917589] start_kcs_transaction - 18 42 01
>>>>>>> [  570.918588] start_kcs_transaction - 18 42 01
>>>>>>> [  570.919677] start_kcs_transaction - 30 02 01 00 00 00
>>>>>>> [  570.920727] start_kcs_transaction - 30 02 01 01 00 00
>>>>>>> [  570.921680] start_kcs_transaction - 30 02 01 02 00 00
>>>>>>> [  570.922731] start_kcs_transaction - 30 02 01 04 00 00
>>>>>>> [  570.923806] start_kcs_transaction - 30 02 01 03 00 00
>>>>>>> [  570.924843] start_kcs_transaction - 30 02 01 06 00 00
>>>>>>> [  570.925853] start_kcs_transaction - 30 02 01 05 00 00
>>>>>>> [  571.027182] start_kcs_transaction - 30 02 01 10 00 00
>>>>>>> [  571.028519] start_kcs_transaction - 30 02 01 07 00 00
>>>>>>> [  571.029595] start_kcs_transaction - 30 02 01 0a 00 00
>>>>>>> [  571.030553] start_kcs_transaction - 30 02 01 0b 00 00
>>>>>>> [  571.031526] start_kcs_transaction - 30 02 01 0c 00 00
>>>>>>> [  571.032569] start_kcs_transaction - 30 02 01 0d 00 00
>>>>>>> [  571.033726] start_kcs_transaction - 30 02 01 0e 00 00
>>>>>>> [  571.034723] start_kcs_transaction - 30 02 01 0f 00 00
>>>>>>> [  571.035851] start_kcs_transaction - 30 02 01 14 00 00
>>>>>>> [  571.036820] start_kcs_transaction - 30 02 01 15 00 00
>>>>>>> [  571.037790] start_kcs_transaction - 30 02 01 16 00 00
>>>>>>> [  571.038791] start_kcs_transaction - 30 02 01 17 00 00
>>>>>>> [  571.039957] start_kcs_transaction - 30 02 01 18 00 00
>>>>>>> -- 
>>>>>>> Henrik Korkuc
>>>>>>>
>>>>>>>
>>>>>>> ------------------------------------------------------------------------------
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> Openipmi-developer mailing list
>>>>>>> [email protected]
>>>>>>> https://lists.sourceforge.net/lists/listinfo/openipmi-developer
>>>
>
>


------------------------------------------------------------------------------
_______________________________________________
Openipmi-developer mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openipmi-developer

Reply via email to